Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 339723002: Revert of Revert of IDL: Support optional argument default value syntax (Closed)

Created:
6 years, 6 months ago by Stephen Chennney
Modified:
6 years, 6 months ago
CC:
blink-reviews, eae+blinkwatch, eric.carlson_apple.com, kinuko+worker_chromium.org, rwlbuis, arv+blink, blink-reviews-css, blink-reviews-html_chromium.org, alecflett, abarth-chromium, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, rune+blink, sof, dgrogan, philipj_slow, feature-media-reviews_chromium.org, ericu+idb_chromium.org, darktears, jsbell+idb_chromium.org, falken, ed+blinkwatch_opera.com, Inactive, cmumford, horo+watch_chromium.org, watchdog-blink-watchlist_google.com, apavlov+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Revert of IDL: Support optional argument default value syntax (https://codereview.chromium.org/339683002/) Reason for revert: Revert the revert because the bot went green even without this revert, and other bots had no trouble. Original issue's description: > Revert of IDL: Support optional argument default value syntax (https://codereview.chromium.org/312683005/) > > Reason for revert: > This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905 > > BrowserTestBase signal handler received SIGTERM. Backtrace: > #0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace() > #1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #2 0x7f2c232cd4a0 \u003Cunknown> > #3 0x7f2c2337f313 __poll > #4 0x7f2c240b6036 \u003Cunknown> > #5 0x7f2c240b6164 g_main_context_iteration > #6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run() > #7 0x7f2c2a29eed7 base::MessageLoop::RunHandler() > #8 0x7f2c2a2f69d8 base::RunLoop::Run() > #9 0x00000466bd59 content::RunThisRunLoop() > #10 0x00000466c1b8 content::MessageLoopRunner::Run() > #11 0x000004610946 content::TitleWatcher::WaitAndGetTitle() > #12 0x0000011fdf00 MediaBrowserTest::RunTest() > #13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage() > #14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage() > #15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange() > #16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread() > ... > > Please look into it. An alterate possible candidate is https://codereview.chromium.org/327553002 but I think that's less likely. > > Original issue's description: > > IDL: Support optional argument default value syntax > > > > Adds support for parsing default values of different types, but > > only handles null default values when generating code. > > > > Replaces existing > > > > [Default=Null] optional SomeInterface arg > > [Default=NullString] optional DOMString arg > > > > with the now equivalent > > > > optional SomeInterface arg = null > > optional DOMString arg = null > > > > in IDL files, and drops support for those [Default] attributes. > > > > No changes to generated code. > > > > BUG=258153 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200 > > TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com > NOTREECHECKS=true > NOTRY=true > BUG=258153 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176220 TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com NOTREECHECKS=true NOTRY=true BUG=258153 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176231

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -74 lines) Patch
M Source/bindings/IDLExtendedAttributes.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/idl_definitions.py View 3 chunks +56 lines, -0 lines 0 comments Download
M Source/bindings/scripts/v8_methods.py View 2 chunks +7 lines, -3 lines 0 comments Download
M Source/bindings/tests/idls/TestInterfaceConstructor2.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/idls/TestObject.idl View 3 chunks +11 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 7 chunks +167 lines, -20 lines 0 comments Download
M Source/bindings/v8/V8Binding.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSStyleDeclaration.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/FontFaceSet.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/WebKitCSSMatrix.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Comment.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMError.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMImplementation.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Text.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/ConsoleBase.idl View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/frame/Window.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLAudioElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDialogElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptionElement.idl View 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/TypeConversions.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/Performance.idl View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/workers/SharedWorker.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encoding/TextDecoder.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encoding/TextEncoder.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBDatabase.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBIndex.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBObjectStore.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Stephen Chennney
Created Revert of Revert of IDL: Support optional argument default value syntax
6 years, 6 months ago (2014-06-16 18:23:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/schenney@chromium.org/339723002/1
6 years, 6 months ago (2014-06-16 18:24:09 UTC) #2
commit-bot: I haz the power
Change committed as 176231
6 years, 6 months ago (2014-06-16 18:27:02 UTC) #3
haraken
6 years, 6 months ago (2014-06-16 23:10:11 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698