Issue 339713005: Remove MaskedViewTargeter and its derived classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339713005: Remove MaskedViewTargeter and its derived classes (Closed)

Created:
6 years, 6 months ago by tdanderson

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org, sadrul

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove MaskedViewTargeter and its derived classes Revert the changes made to introduce MaskedViewTargeter and its derived classes (r273023, r274041, and r273740), but keep the unit test SpeechViewTest.ClickMicButton. This change is necessary for the new approach of introducing ViewTargeterDelegate/MaskedTargeterDelegate instead of subclassing ViewTargeter. See crbug.com/388838 for a detailed explanation. BUG=388838 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279846

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -280 lines)			Patch
M	chrome/browser/ui/views/tabs/tab_strip.cc	View	4 chunks	+18 lines, -48 lines	0 comments	Download
M	ui/app_list/views/speech_view.cc	View	3 chunks	+10 lines, -38 lines	0 comments	Download
D	ui/views/masked_view_targeter.h	View	1 chunk	+0 lines, -46 lines	0 comments	Download
D	ui/views/masked_view_targeter.cc	View	1 chunk	+0 lines, -46 lines	0 comments	Download
M	ui/views/view.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ui/views/view.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ui/views/view_targeter_unittest.cc	View	2 chunks	+0 lines, -94 lines	0 comments	Download
M	ui/views/views.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/339713005/1

6 years, 6 months ago (2014-06-25 22:54:42 UTC) #4

Message was sent while issue was closed.

Change committed as 279846

Expand Messages | Collapse Messages