Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 339703004: Oilpan: Make sure XMLTreeViewer::m_document is traceable. (Closed)

Created:
6 years, 6 months ago by tkent
Modified:
6 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Oilpan: Make sure XMLTreeViewer::m_document is traceable. - Mark XMLTreeViewer STACK_ALLOCATED(). - Make m_document Member<>. BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176263

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Source/core/xml/XMLTreeViewer.h View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tkent
Please review this.
6 years, 6 months ago (2014-06-17 00:28:04 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-17 00:33:38 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-17 01:38:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/339703004/1
6 years, 6 months ago (2014-06-17 01:39:00 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 01:56:15 UTC) #5
Message was sent while issue was closed.
Change committed as 176263

Powered by Google App Engine
This is Rietveld 408576698