Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 339703002: Fix audit_runtime_enabled_features now that omahaproxy has headers in their CSV (Closed)

Created:
6 years, 6 months ago by eseidel
Modified:
6 years, 6 months ago
Reviewers:
Robert Sesek
CC:
blink-reviews, laforge, dpranke_chromioum.org, ojan, abarth-chromium, Robert Sesek
Visibility:
Public.

Description

Fix audit_runtime_enabled_features now that omahaproxy has headers in their CSV BUG=371746 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176241

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M Source/build/scripts/audit_runtime_enabled_features.py View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
eseidel
I don't know who maintains omahaproxy, but this should be a trivial python review.
6 years, 6 months ago (2014-06-16 17:57:20 UTC) #1
eseidel
6 years, 6 months ago (2014-06-16 18:40:51 UTC) #2
Robert Sesek
lgtm
6 years, 6 months ago (2014-06-16 18:45:02 UTC) #3
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 6 months ago (2014-06-16 18:46:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/339703002/1
6 years, 6 months ago (2014-06-16 18:46:56 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 20:44:52 UTC) #6
Message was sent while issue was closed.
Change committed as 176241

Powered by Google App Engine
This is Rietveld 408576698