src/x64/assembler-x64-inl.h - Issue 3397021: [Isolates] StaticVisitor::VisitPointer gets Heap* as additional argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/assembler-x64-inl.h

Issue 3397021: [Isolates] StaticVisitor::VisitPointer gets Heap* as additional argument (Closed)

Patch Set: Added CODE_POINTER_ALIGN per Vitaly's suggestion. Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/assembler-x64-inl.h

diff --git a/src/x64/assembler-x64-inl.h b/src/x64/assembler-x64-inl.h

index 3e6b728dd3cea894dbc7c2d6073d38c962e483de..a7bce5b73da0d0b3e4da084ab3344f70a716f449 100644

--- a/src/x64/assembler-x64-inl.h

+++ b/src/x64/assembler-x64-inl.h

@@ -352,16 +352,16 @@ void RelocInfo::Visit(ObjectVisitor* visitor) {

template<typename StaticVisitor>

-void RelocInfo::Visit() {

+void RelocInfo::Visit(Heap* heap) {

RelocInfo::Mode mode = rmode();

if (mode == RelocInfo::EMBEDDED_OBJECT) {

- StaticVisitor::VisitPointer(target_object_address());

+ StaticVisitor::VisitPointer(heap, target_object_address());

} else if (RelocInfo::IsCodeTarget(mode)) {

StaticVisitor::VisitCodeTarget(this);

} else if (mode == RelocInfo::EXTERNAL_REFERENCE) {

StaticVisitor::VisitExternalReference(target_reference_address());

#ifdef ENABLE_DEBUGGER_SUPPORT

- } else if (Isolate::Current()->debug()->has_break_points() &&

+ } else if (heap->isolate()->debug()->has_break_points() &&

((RelocInfo::IsJSReturn(mode) &&

IsPatchedReturnSequence()) ||

(RelocInfo::IsDebugBreakSlot(mode) &&

« no previous file with comments | « src/spaces.h ('k') | test/cctest/test-spaces.cc » ('j') | no next file with comments »