Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: src/ia32/assembler-ia32-inl.h

Issue 3397021: [Isolates] StaticVisitor::VisitPointer gets Heap* as additional argument (Closed)
Patch Set: Added CODE_POINTER_ALIGN per Vitaly's suggestion. Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap.cc ('k') | src/mark-compact.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 Isolate::Current()->debug()->has_break_points()) { 178 Isolate::Current()->debug()->has_break_points()) {
179 visitor->VisitDebugTarget(this); 179 visitor->VisitDebugTarget(this);
180 #endif 180 #endif
181 } else if (mode == RelocInfo::RUNTIME_ENTRY) { 181 } else if (mode == RelocInfo::RUNTIME_ENTRY) {
182 visitor->VisitRuntimeEntry(this); 182 visitor->VisitRuntimeEntry(this);
183 } 183 }
184 } 184 }
185 185
186 186
187 template<typename StaticVisitor> 187 template<typename StaticVisitor>
188 void RelocInfo::Visit() { 188 void RelocInfo::Visit(Heap* heap) {
189 RelocInfo::Mode mode = rmode(); 189 RelocInfo::Mode mode = rmode();
190 if (mode == RelocInfo::EMBEDDED_OBJECT) { 190 if (mode == RelocInfo::EMBEDDED_OBJECT) {
191 StaticVisitor::VisitPointer(target_object_address()); 191 StaticVisitor::VisitPointer(heap, target_object_address());
192 } else if (RelocInfo::IsCodeTarget(mode)) { 192 } else if (RelocInfo::IsCodeTarget(mode)) {
193 StaticVisitor::VisitCodeTarget(this); 193 StaticVisitor::VisitCodeTarget(this);
194 } else if (mode == RelocInfo::EXTERNAL_REFERENCE) { 194 } else if (mode == RelocInfo::EXTERNAL_REFERENCE) {
195 StaticVisitor::VisitExternalReference(target_reference_address()); 195 StaticVisitor::VisitExternalReference(target_reference_address());
196 #ifdef ENABLE_DEBUGGER_SUPPORT 196 #ifdef ENABLE_DEBUGGER_SUPPORT
197 } else if (Isolate::Current()->debug()->has_break_points() && 197 } else if (heap->isolate()->debug()->has_break_points() &&
198 ((RelocInfo::IsJSReturn(mode) && 198 ((RelocInfo::IsJSReturn(mode) &&
199 IsPatchedReturnSequence()) || 199 IsPatchedReturnSequence()) ||
200 (RelocInfo::IsDebugBreakSlot(mode) && 200 (RelocInfo::IsDebugBreakSlot(mode) &&
201 IsPatchedDebugBreakSlotSequence()))) { 201 IsPatchedDebugBreakSlotSequence()))) {
202 StaticVisitor::VisitDebugTarget(this); 202 StaticVisitor::VisitDebugTarget(this);
203 #endif 203 #endif
204 } else if (mode == RelocInfo::RUNTIME_ENTRY) { 204 } else if (mode == RelocInfo::RUNTIME_ENTRY) {
205 StaticVisitor::VisitRuntimeEntry(this); 205 StaticVisitor::VisitRuntimeEntry(this);
206 } 206 }
207 } 207 }
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 377
378 Operand::Operand(int32_t disp, RelocInfo::Mode rmode) { 378 Operand::Operand(int32_t disp, RelocInfo::Mode rmode) {
379 // [disp/r] 379 // [disp/r]
380 set_modrm(0, ebp); 380 set_modrm(0, ebp);
381 set_dispr(disp, rmode); 381 set_dispr(disp, rmode);
382 } 382 }
383 383
384 } } // namespace v8::internal 384 } } // namespace v8::internal
385 385
386 #endif // V8_IA32_ASSEMBLER_IA32_INL_H_ 386 #endif // V8_IA32_ASSEMBLER_IA32_INL_H_
OLDNEW
« no previous file with comments | « src/heap.cc ('k') | src/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698