Add a probability to Alternate-Protocol support.

Add a probability to Alternate-Protocol support. Can be enabled either via a field trial or a command line flag.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281777

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281861

[ramant (doing other things), 2014-06-27 22:38:13]

lgtm

https://codereview.chromium.org/339663010/diff/80001/chrome/browser/net/http_...
File chrome/browser/net/http_server_properties_manager.cc (right):

https://codereview.chromium.org/339663010/diff/80001/chrome/browser/net/http_...
chrome/browser/net/http_server_properties_manager.cc:223:
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
Thanks for adding the DCHECKs.

https://codereview.chromium.org/339663010/diff/80001/chrome/common/chrome_swi...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/339663010/diff/80001/chrome/common/chrome_swi...
chrome/common/chrome_switches.cc:56: // advertisment will be honored. If the
advertised probability is larger
nit: advertisment -> advertisement

https://codereview.chromium.org/339663010/diff/80001/net/http/http_server_pro...
File net/http/http_server_properties.h (right):

https://codereview.chromium.org/339663010/diff/80001/net/http/http_server_pro...
net/http/http_server_properties.h:98: double probability)
nit: lines 97-98 indentation could be wrong.

https://codereview.chromium.org/339663010/diff/80001/net/http/http_server_pro...
File net/http/http_server_properties_impl.cc (right):

https://codereview.chromium.org/339663010/diff/80001/net/http/http_server_pro...
net/http/http_server_properties_impl.cc:138: const AlternateProtocolInfo& pair)
{
nit: please consider changing variable name of |pair|.

https://codereview.chromium.org/339663010/diff/80001/net/http/http_stream_fac...
File net/http/http_stream_factory.cc (right):

https://codereview.chromium.org/339663010/diff/80001/net/http/http_stream_fac...
net/http/http_stream_factory.cc:39: for (size_t i = 0; i <
alternate_protocol_values.size(); ++i) {
Small question: Can alternate_protocol_values have more than 2 strings? I am
assuming alternate_protocol_values.size() will be less than 2.

https://codereview.chromium.org/339663010/diff/80001/net/http/http_stream_fac...
net/http/http_stream_factory.cc:52: 
nit: extra blank line.

https://codereview.chromium.org/339663010/diff/80001/net/http/http_stream_fac...
File net/http/http_stream_factory.h (right):

https://codereview.chromium.org/339663010/diff/80001/net/http/http_stream_fac...
net/http/http_stream_factory.h:182: const std::vector<std::string>&
alternate_protocol_valuse,
nit: valuse  -> values

https://codereview.chromium.org/339663010/diff/80001/net/quic/quic_network_tr...
File net/quic/quic_network_transaction_unittest.cc (right):

https://codereview.chromium.org/339663010/diff/80001/net/quic/quic_network_tr...
net/quic/quic_network_transaction_unittest.cc:55: "Alternate-Protocol:
80:quic,p=.5\r\n\r\n";
nit: Can one send a header with p less than 0 (or p > 1.0)? Wondering if that is
a valid header.

https://codereview.chromium.org/339663010/diff/80001/net/quic/quic_network_tr...
net/quic/quic_network_transaction_unittest.cc:546: 
nit: extra blank line.

[Ryan Hamilton, 2014-06-30 19:02:35]

thestig: chrome/browser/io_thread.* and chrome/common/chrome_switches.* OWNERS
review, please.

https://codereview.chromium.org/339663010/diff/80001/chrome/browser/net/http_...
File chrome/browser/net/http_server_properties_manager.cc (right):

https://codereview.chromium.org/339663010/diff/80001/chrome/browser/net/http_...
chrome/browser/net/http_server_properties_manager.cc:223:
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
On 2014/06/27 22:38:13, ramant wrote:
> Thanks for adding the DCHECKs.

My pleasure!

https://codereview.chromium.org/339663010/diff/80001/chrome/common/chrome_swi...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/339663010/diff/80001/chrome/common/chrome_swi...
chrome/common/chrome_switches.cc:56: // advertisment will be honored. If the
advertised probability is larger
On 2014/06/27 22:38:13, ramant wrote:
> nit: advertisment -> advertisement

Done.

https://codereview.chromium.org/339663010/diff/80001/net/http/http_server_pro...
File net/http/http_server_properties.h (right):

https://codereview.chromium.org/339663010/diff/80001/net/http/http_server_pro...
net/http/http_server_properties.h:98: double probability)
On 2014/06/27 22:38:13, ramant wrote:
> nit: lines 97-98 indentation could be wrong.

Doh! Sorry for not catching this.

https://codereview.chromium.org/339663010/diff/80001/net/http/http_server_pro...
File net/http/http_server_properties_impl.cc (right):

https://codereview.chromium.org/339663010/diff/80001/net/http/http_server_pro...
net/http/http_server_properties_impl.cc:138: const AlternateProtocolInfo& pair)
{
On 2014/06/27 22:38:13, ramant wrote:
> nit: please consider changing variable name of |pair|.

Done.

https://codereview.chromium.org/339663010/diff/80001/net/http/http_stream_fac...
File net/http/http_stream_factory.cc (right):

https://codereview.chromium.org/339663010/diff/80001/net/http/http_stream_fac...
net/http/http_stream_factory.cc:39: for (size_t i = 0; i <
alternate_protocol_values.size(); ++i) {
On 2014/06/27 22:38:13, ramant wrote:
> Small question: Can alternate_protocol_values have more than 2 strings? I am
> assuming alternate_protocol_values.size() will be less than 2.

If a server said:

Alternate-Protocol: 443:quic,443:npn-spdy,443:something-else

Then alternate_protocol_values would contain 3 strings. Does this sound right to
you?

https://codereview.chromium.org/339663010/diff/80001/net/http/http_stream_fac...
net/http/http_stream_factory.cc:52: 
On 2014/06/27 22:38:13, ramant wrote:
> nit: extra blank line.

Done.

https://codereview.chromium.org/339663010/diff/80001/net/http/http_stream_fac...
File net/http/http_stream_factory.h (right):

https://codereview.chromium.org/339663010/diff/80001/net/http/http_stream_fac...
net/http/http_stream_factory.h:182: const std::vector<std::string>&
alternate_protocol_valuse,
On 2014/06/27 22:38:13, ramant wrote:
> nit: valuse  -> values

Done.

https://codereview.chromium.org/339663010/diff/80001/net/quic/quic_network_tr...
File net/quic/quic_network_transaction_unittest.cc (right):

https://codereview.chromium.org/339663010/diff/80001/net/quic/quic_network_tr...
net/quic/quic_network_transaction_unittest.cc:55: "Alternate-Protocol:
80:quic,p=.5\r\n\r\n";
On 2014/06/27 22:38:13, ramant wrote:
> nit: Can one send a header with p less than 0 (or p > 1.0)? Wondering if that
is
> a valid header.

No, the valid range is [0,1]. Added a test for an invalid value.

[Lei Zhang, 2014-06-30 19:09:25]

lgtm

https://codereview.chromium.org/339663010/diff/100001/chrome/browser/net/http...
File chrome/browser/net/http_server_properties_manager.cc (right):

https://codereview.chromium.org/339663010/diff/100001/chrome/browser/net/http...
chrome/browser/net/http_server_properties_manager.cc:223:
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
Please use DCHECK_CURRENTLY_ON.

https://codereview.chromium.org/339663010/diff/100001/chrome/common/chrome_sw...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/339663010/diff/100001/chrome/common/chrome_sw...
chrome/common/chrome_switches.cc:59: "alternate-protocol-probability-threshold";
Is "alternative protocol" too generic? Do you want quic in the name somewhere?

[ramant (doing other things), 2014-06-30 21:01:24]

lgtm

https://codereview.chromium.org/339663010/diff/80001/net/http/http_stream_fac...
File net/http/http_stream_factory.cc (right):

https://codereview.chromium.org/339663010/diff/80001/net/http/http_stream_fac...
net/http/http_stream_factory.cc:39: for (size_t i = 0; i <
alternate_protocol_values.size(); ++i) {
On 2014/06/30 19:02:34, Ryan Hamilton wrote:
> On 2014/06/27 22:38:13, ramant wrote:
> > Small question: Can alternate_protocol_values have more than 2 strings? I am
> > assuming alternate_protocol_values.size() will be less than 2.
> 
> If a server said:
> 
> Alternate-Protocol: 443:quic,443:npn-spdy,443:something-else
> 
> Then alternate_protocol_values would contain 3 strings. Does this sound right
to
> you?
SGTM

https://codereview.chromium.org/339663010/diff/80001/net/quic/quic_network_tr...
File net/quic/quic_network_transaction_unittest.cc (right):

https://codereview.chromium.org/339663010/diff/80001/net/quic/quic_network_tr...
net/quic/quic_network_transaction_unittest.cc:55: "Alternate-Protocol:
80:quic,p=.5\r\n\r\n";
On 2014/06/30 19:02:35, Ryan Hamilton wrote:
> On 2014/06/27 22:38:13, ramant wrote:
> > nit: Can one send a header with p less than 0 (or p > 1.0)? Wondering if
that
> is
> > a valid header.
> 
> No, the valid range is [0,1]. Added a test for an invalid value.

Great.

[Ryan Hamilton, 2014-06-30 21:33:01]

https://codereview.chromium.org/339663010/diff/100001/chrome/browser/net/http...
File chrome/browser/net/http_server_properties_manager.cc (right):

https://codereview.chromium.org/339663010/diff/100001/chrome/browser/net/http...
chrome/browser/net/http_server_properties_manager.cc:223:
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
On 2014/06/30 19:09:24, Lei Zhang wrote:
> Please use DCHECK_CURRENTLY_ON.

Done.

https://codereview.chromium.org/339663010/diff/100001/chrome/common/chrome_sw...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/339663010/diff/100001/chrome/common/chrome_sw...
chrome/common/chrome_switches.cc:59: "alternate-protocol-probability-threshold";
On 2014/06/30 19:09:24, Lei Zhang wrote:
> Is "alternative protocol" too generic? Do you want quic in the name somewhere?

Alternate Protocol is actually not QUIC specific (it applies to any other
protocol like SPDY or HTTP2, as well) so I think QUIC probably does not belong
in the name.

[Ryan Hamilton, 2014-07-01 19:12:37]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2014-07-01 19:14:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rch@chromium.org/339663010/140001

[commit-bot: I haz the power, 2014-07-01 20:13:49]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/23765)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/28169)

[commit-bot: I haz the power, 2014-07-01 20:16:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-01 20:16:01]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/23791)

[Ryan Hamilton, 2014-07-01 22:16:08]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2014-07-01 22:17:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rch@chromium.org/339663010/160001

[Ryan Hamilton, 2014-07-01 22:48:14]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2014-07-01 22:48:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rch@chromium.org/339663010/180001

[Ryan Hamilton, 2014-07-01 23:46:03]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2014-07-01 23:47:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rch@chromium.org/339663010/200001

[commit-bot: I haz the power, 2014-07-02 00:41:13]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/23883)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/28287)

[commit-bot: I haz the power, 2014-07-02 00:43:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-02 00:43:29]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/23903)

[Ryan Hamilton, 2014-07-02 19:59:55]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2014-07-02 20:00:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rch@chromium.org/339663010/220001

[commit-bot: I haz the power, 2014-07-02 21:06:31]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/28665)

[commit-bot: I haz the power, 2014-07-02 21:12:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-02 21:12:42]

Try jobs failed on following builders:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)

[Ryan Hamilton, 2014-07-02 22:43:45]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2014-07-02 22:45:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rch@chromium.org/339663010/220001

[Ryan Hamilton, 2014-07-03 02:26:39]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2014-07-03 02:29:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rch@chromium.org/339663010/240001

[Ryan Hamilton, 2014-07-03 03:33:44]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2014-07-03 03:38:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rch@chromium.org/339663010/260001

[Ryan Hamilton, 2014-07-03 04:01:37]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2014-07-03 04:02:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rch@chromium.org/339663010/280001

[commit-bot: I haz the power, 2014-07-03 07:45:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-03 08:53:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-03 08:53:36]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[Ryan Hamilton, 2014-07-03 14:58:29]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2014-07-03 14:59:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rch@chromium.org/339663010/300001

[commit-bot: I haz the power, 2014-07-03 19:16:46]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-03 20:19:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-03 20:19:11]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[Ryan Hamilton, 2014-07-07 17:35:38]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2014-07-07 17:36:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rch@chromium.org/339663010/320001

[commit-bot: I haz the power, 2014-07-07 19:49:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-07-07 19:58:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-07 19:58:48]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[Ryan Hamilton, 2014-07-07 23:11:10]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2014-07-07 23:13:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rch@chromium.org/339663010/320001

[commit-bot: I haz the power, 2014-07-08 00:35:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-07-08 00:56:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-08 00:56:09]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[Ryan Hamilton, 2014-07-08 16:39:44]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2014-07-08 16:40:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rch@chromium.org/339663010/320001

[commit-bot: I haz the power, 2014-07-08 18:59:46]

Change committed as 281777

[jamesr, 2014-07-08 19:36:38]

https://codereview.chromium.org/339663010/diff/320001/net/http/http_stream_fa...
File net/http/http_stream_factory_impl.cc (right):

https://codereview.chromium.org/339663010/diff/320001/net/http/http_stream_fa...
net/http/http_stream_factory_impl.cc:26: AlternateProtocolInfo(0, 
UNINITIALIZED_ALTERNATE_PROTOCOL, 0);
this creates a static initializer

[samuong, 2014-07-08 19:38:26]

A revert of this CL has been created in
https://codereview.chromium.org/377063002/ by samuong@chromium.org.

The reason for reverting is: causes sizes step to fail on linux x64 due to extra
static initializers:

http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/67438.

[Ryan Hamilton, 2014-07-08 19:59:52]

https://codereview.chromium.org/339663010/diff/320001/net/http/http_stream_fa...
File net/http/http_stream_factory_impl.cc (right):

https://codereview.chromium.org/339663010/diff/320001/net/http/http_stream_fa...
net/http/http_stream_factory_impl.cc:26: AlternateProtocolInfo(0, 
UNINITIALIZED_ALTERNATE_PROTOCOL, 0);
On 2014/07/08 19:36:38, jamesr wrote:
> this creates a static initializer

Ugh! Yes, it does :< Sorry about that.

Fixed.

[Ryan Hamilton, 2014-07-08 19:59:57]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2014-07-08 20:05:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rch@chromium.org/339663010/340001

[commit-bot: I haz the power, 2014-07-08 23:01:05]

Change committed as 281861