Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 339663003: Revert of Implement NativeViewHostAura::InstallClip. (Closed)

Created:
6 years, 6 months ago by jackhou1
Modified:
6 years, 6 months ago
Reviewers:
calamity, sky
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Revert of Implement NativeViewHostAura::InstallClip. (https://codereview.chromium.org/317823002/) Reason for revert: Breaking ASan LSan: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/4038 http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/4410 Original issue's description: > Implement NativeViewHostAura::InstallClip. > > Despite the NOTIMPLEMENTED comment saying that this method is only > needed for performance, it causes bugs with aura windows in side > Bubbles which need to clip to their parent view rather than the parent > window. > > This CL is based on https://codereview.chromium.org/30993004/ but strips > out the gravity code and simplifies the windowing code. > > Since the window hierarchy of NPAPI plugins has changed due to this > patch, it was also necessary to modify WebContentsViewAura to reflect > this change. > > BUG=377378 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279051 TBR=calamity@chromium.org,sky@chromium.org NOTRY=true NOTREECHECKS=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -290 lines) Patch
M content/browser/web_contents/web_contents_view_aura.cc View 10 chunks +33 lines, -40 lines 0 comments Download
M ui/aura/client/aura_constants.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/aura/client/aura_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/native/native_view_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/controls/native/native_view_host_aura.h View 3 chunks +3 lines, -17 lines 0 comments Download
M ui/views/controls/native/native_view_host_aura.cc View 5 chunks +15 lines, -76 lines 0 comments Download
M ui/views/controls/native/native_view_host_aura_unittest.cc View 7 chunks +2 lines, -125 lines 0 comments Download
M ui/views/controls/native/native_view_host_unittest.cc View 2 chunks +1 line, -13 lines 0 comments Download
M ui/views/controls/native/native_view_host_wrapper.h View 2 chunks +6 lines, -11 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jackhou1
Created Revert of Implement NativeViewHostAura::InstallClip.
6 years, 6 months ago (2014-06-23 06:53:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/339663003/1
6 years, 6 months ago (2014-06-23 06:54:01 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-23 06:54:02 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-23 06:54:02 UTC) #4
jackhou1
The CQ bit was checked by jackhou@chromium.org
6 years, 6 months ago (2014-06-23 06:55:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/339663003/1
6 years, 6 months ago (2014-06-23 06:56:04 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 06:56:59 UTC) #7
Message was sent while issue was closed.
Change committed as 279053

Powered by Google App Engine
This is Rietveld 408576698