media/filters/gpu_video_decoder.cc - Issue 339653003: No EOS frame in {Audio|Video}Decoder::OutputCB.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/gpu_video_decoder.cc

Issue 339653003: No EOS frame in {Audio|Video}Decoder::OutputCB. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase only Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/gpu_video_decoder.cc

diff --git a/media/filters/gpu_video_decoder.cc b/media/filters/gpu_video_decoder.cc

index e2b4f7fa4dd43267fffb426c2c2160b1101db116..bc545b7d652ca912918483fd23b8f47590d8d098 100644

--- a/media/filters/gpu_video_decoder.cc

+++ b/media/filters/gpu_video_decoder.cc

@@ -148,7 +148,7 @@ static void ReportGpuVideoDecoderInitializeStatusToUMAAndRunCB(

}

void GpuVideoDecoder::Initialize(const VideoDecoderConfig& config,

- bool live_mode,

+ bool /* low_delay */,

const PipelineStatusCB& orig_status_cb,

const OutputCB& output_cb) {

DVLOG(3) << "Initialize()";

@@ -581,7 +581,6 @@ void GpuVideoDecoder::NotifyFlushDone() {

DCheckGpuVideoAcceleratorFactoriesTaskRunnerIsCurrent();

DCHECK_EQ(state_, kDrainingDecoder);

state_ = kDecoderDrained;

- DeliverFrame(VideoFrame::CreateEOSFrame());

base::ResetAndReturn(&eos_decode_cb_).Run(kOk);

}