media/base/audio_decoder.h - Issue 339653003: No EOS frame in {Audio|Video}Decoder::OutputCB.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/audio_decoder.h

Issue 339653003: No EOS frame in {Audio|Video}Decoder::OutputCB. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase only Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/audio_decoder.h

diff --git a/media/base/audio_decoder.h b/media/base/audio_decoder.h

index 285d91b952ef6dd6828bc4944aaba345999ee889..0118b5e4fdd57f9893dbd92ed561ace6a6819c0d 100644

--- a/media/base/audio_decoder.h

+++ b/media/base/audio_decoder.h

@@ -30,7 +30,8 @@ class MEDIA_EXPORT AudioDecoder {

kDecryptError // Decrypting error happened.

};

- // Callback to return decoded buffers.

+ // Callback for AudioDecoder to return a decoded frame whenever it becomes

+ // available. Only non-EOS frames should be returned via this callback.

typedef base::Callback<void(const scoped_refptr<AudioBuffer>&)> OutputCB;

// Callback for Decode(). Called after the decoder has completed decoding

« no previous file with comments | « no previous file | media/base/video_decoder.h » ('j') | media/filters/ffmpeg_audio_decoder.h » ('J')