No EOS frame in {Audio|Video}Decoder::OutputCB.

media/filters/ffmpeg_audio_decoder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/filters/ffmpeg_audio_decoder.h"
 
 #include "base/callback_helpers.h"
 #include "base/single_thread_task_runner.h"
 #include "media/base/audio_buffer.h"
 #include "media/base/audio_bus.h"
@@ skipping 195 matching lines @@
 void FFmpegAudioDecoder::DecodeBuffer(
     const scoped_refptr<DecoderBuffer>& buffer,
     const DecodeCB& decode_cb) {
   DCHECK(task_runner_->BelongsToCurrentThread());
   DCHECK_NE(state_, kUninitialized);
   DCHECK_NE(state_, kDecodeFinished);
   DCHECK_NE(state_, kError);
 
   DCHECK(buffer);
 
-  // During decode, because reads are issued asynchronously, it is possible to
-  // receive multiple end of stream buffers since each decode is acked. When the
-  // first end of stream buffer is read, FFmpeg may still have frames queued
-  // up in the decoder so we need to go through the decode loop until it stops
-  // giving sensible data.  After that, the decoder should output empty
-  // frames.  There are three states the decoder can be in:
-  //
-  //   kNormal: This is the starting state. Buffers are decoded. Decode errors
-  //            are discarded.
-  //   kFlushCodec: There isn't any more input data. Call avcodec_decode_audio4
-  //                until no more data is returned to flush out remaining
-  //                frames. The input buffer is ignored at this point.
-  //   kDecodeFinished: All calls return empty frames.
-  //   kError: Unexpected error happened.
-  //
-  // These are the possible state transitions.
-  //
-  // kNormal -> kFlushCodec:
-  //     When buffer->end_of_stream() is first true.
-  // kNormal -> kError:
-  //     A decoding error occurs and decoding needs to stop.
-  // kFlushCodec -> kDecodeFinished:
-  //     When avcodec_decode_audio4() returns 0 data.
-  // kFlushCodec -> kError:
-  //     When avcodec_decode_audio4() errors out.
-  // (any state) -> kNormal:
-  //     Any time Reset() is called.
-
   // Make sure we are notified if http://crbug.com/49709 returns.  Issue also
   // occurs with some damaged files.
   if (!buffer->end_of_stream() && buffer->timestamp() == kNoTimestamp()) {
     DVLOG(1) << "Received a buffer without timestamps!";
     decode_cb.Run(kDecodeError);
     return;
   }
 
-  if (!FFmpegDecode(buffer)) {
-    state_ = kError;
-    decode_cb.Run(kDecodeError);
-    return;
-  }
+  bool has_produced_frame;
+  do {
+    has_produced_frame = false;
+    if (!FFmpegDecode(buffer, &has_produced_frame)) {
+      state_ = kError;
+      decode_cb.Run(kDecodeError);
+      return;
+    }
+    // Repeat to flush the decoder after receiving EOS buffer.
+  } while (buffer->end_of_stream() && has_produced_frame);
 
-  if (buffer->end_of_stream()) {
+  if (buffer->end_of_stream())
     state_ = kDecodeFinished;
-    output_cb_.Run(AudioBuffer::CreateEOSBuffer());
-  }
 
   decode_cb.Run(kOk);
 }
 
 bool FFmpegAudioDecoder::FFmpegDecode(
-    const scoped_refptr<DecoderBuffer>& buffer) {
+    const scoped_refptr<DecoderBuffer>& buffer,
+    bool* has_produced_frame) {
+  DCHECK(!*has_produced_frame);
+
   AVPacket packet;
   av_init_packet(&packet);
   if (buffer->end_of_stream()) {
     packet.data = NULL;
     packet.size = 0;
   } else {
     packet.data = const_cast<uint8*>(buffer->data());
     packet.size = buffer->data_size();
   }
 
@@ skipping 62 matching lines @@
       DCHECK_GE(unread_frames, 0);
       if (unread_frames > 0)
         output->TrimEnd(unread_frames);
       av_frame_unref(av_frame_.get());
     }
 
     // WARNING: |av_frame_| no longer has valid data at this point.
     const int decoded_frames = frame_decoded ? output->frame_count() : 0;
     if (IsEndOfStream(result, decoded_frames, buffer)) {
       DCHECK_EQ(packet.size, 0);
-      output_cb_.Run(AudioBuffer::CreateEOSBuffer());
     } else if (discard_helper_->ProcessBuffers(buffer, output)) {
+      *has_produced_frame = true;
       output_cb_.Run(output);
     }
   } while (packet.size > 0);
 
   return true;
 }
 
 void FFmpegAudioDecoder::ReleaseFFmpegResources() {
   codec_context_.reset();
   av_frame_.reset();
@@ skipping 53 matching lines @@
 
   ResetTimestampState();
   return true;
 }
 
 void FFmpegAudioDecoder::ResetTimestampState() {
   discard_helper_->Reset(config_.codec_delay());
 }
 
 }  // namespace media