No EOS frame in {Audio|Video}Decoder::OutputCB.

media/filters/ffmpeg_audio_decoder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/filters/ffmpeg_audio_decoder.h"
 
 #include "base/callback_helpers.h"
 #include "base/single_thread_task_runner.h"
 #include "media/base/audio_buffer.h"
 #include "media/base/audio_bus.h"
@@ skipping 212 matching lines @@
   //   kNormal: This is the starting state. Buffers are decoded. Decode errors
   //            are discarded.
   //   kFlushCodec: There isn't any more input data. Call avcodec_decode_audio4
   //                until no more data is returned to flush out remaining
   //                frames. The input buffer is ignored at this point.
   //   kDecodeFinished: All calls return empty frames.
   //   kError: Unexpected error happened.
   //
   // These are the possible state transitions.
   //
   // kNormal -> kFlushCodec:

[DaleCurtis, 2014/06/16 18:18:08]

Is this still a valid state?

[xhwang, 2014/06/17 18:56:35]

Thanks for catching this. These comments are super old and are in the wrong
spot. Updated the comments and move them to the header file.

   //     When buffer->end_of_stream() is first true.
   // kNormal -> kError:
   //     A decoding error occurs and decoding needs to stop.
   // kFlushCodec -> kDecodeFinished:
   //     When avcodec_decode_audio4() returns 0 data.
   // kFlushCodec -> kError:
   //     When avcodec_decode_audio4() errors out.
   // (any state) -> kNormal:
   //     Any time Reset() is called.
 
@@ skipping 14 matching lines @@
         discard_helper_->TimeDeltaToFrames(-buffer->timestamp());
     discard_helper_->Reset(discard_frames);
   }
 
   if (!FFmpegDecode(buffer)) {
     state_ = kError;
     decode_cb.Run(kDecodeError);
     return;
   }
 
-  if (buffer->end_of_stream()) {
+  if (buffer->end_of_stream())
     state_ = kDecodeFinished;
-    output_cb_.Run(AudioBuffer::CreateEOSBuffer());
-  }
 
   decode_cb.Run(kOk);
 }
 
 bool FFmpegAudioDecoder::FFmpegDecode(
     const scoped_refptr<DecoderBuffer>& buffer) {
   AVPacket packet;
   av_init_packet(&packet);
   if (buffer->end_of_stream()) {
     packet.data = NULL;
@@ skipping 68 matching lines @@
       DCHECK_GE(unread_frames, 0);
       if (unread_frames > 0)
         output->TrimEnd(unread_frames);
       av_frame_unref(av_frame_.get());
     }
 
     // WARNING: |av_frame_| no longer has valid data at this point.
     const int decoded_frames = frame_decoded ? output->frame_count() : 0;
     if (IsEndOfStream(result, decoded_frames, buffer)) {
       DCHECK_EQ(packet.size, 0);
-      output_cb_.Run(AudioBuffer::CreateEOSBuffer());
     } else if (discard_helper_->ProcessBuffers(buffer, output)) {
       output_cb_.Run(output);
     }
   } while (packet.size > 0);
 
   return true;
 }
 
 void FFmpegAudioDecoder::ReleaseFFmpegResources() {
   codec_context_.reset();
@@ skipping 54 matching lines @@
 
   ResetTimestampState();
   return true;
 }
 
 void FFmpegAudioDecoder::ResetTimestampState() {
   discard_helper_->Reset(config_.codec_delay());
 }
 
 }  // namespace media