Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 339643003: Legalize div/idiv operands to avoid immediates. (Closed)

Created:
6 years, 6 months ago by jvoung (off chromium)
Modified:
6 years, 6 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Legalize div/idiv operands to avoid immediates. The div/idiv instruction operand must be a register or memory. BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=70d6883

Patch Set 1 #

Patch Set 2 : space #

Total comments: 2

Patch Set 3 : default args #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -1 line) Patch
M src/IceTargetLoweringX8632.cpp View 1 2 5 chunks +7 lines, -1 line 0 comments Download
A tests_lit/llvm2ice_tests/div_legalization.ll View 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jvoung (off chromium)
6 years, 6 months ago (2014-06-17 02:14:54 UTC) #1
Jim Stichnoth
LGTM, with small nit. Also, in the CL description, "intermediates" --> "immediates"? https://codereview.chromium.org/339643003/diff/20001/src/IceTargetLoweringX8632.cpp File src/IceTargetLoweringX8632.cpp ...
6 years, 6 months ago (2014-06-17 05:35:06 UTC) #2
jvoung (off chromium)
https://codereview.chromium.org/339643003/diff/20001/src/IceTargetLoweringX8632.cpp File src/IceTargetLoweringX8632.cpp (right): https://codereview.chromium.org/339643003/diff/20001/src/IceTargetLoweringX8632.cpp#newcode1139 src/IceTargetLoweringX8632.cpp:1139: Src1 = legalize(Src1, Legal_Reg | Legal_Mem, true); On 2014/06/17 ...
6 years, 6 months ago (2014-06-17 16:11:08 UTC) #3
jvoung (off chromium)
6 years, 6 months ago (2014-06-17 17:02:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r70d6883 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698