Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2157)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

Issue 339623002: Added support for versioning of layout test results of run-webkit-tests runs (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py b/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
index f203fa534bea2bbdd9c6015dc6172e06caf8116f..a0cac6a19c36cf05e67655472c72259ce7a574d7 100644
--- a/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
+++ b/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
@@ -163,7 +163,7 @@ def _interpret_test_failures(failures):
return test_dict
-def summarize_results(port_obj, expectations, initial_results, retry_results, enabled_pixel_tests_in_retry, only_include_failing=False):
+def summarize_results(port_obj, expectations, initial_results, retry_results, enabled_pixel_tests_in_retry, only_include_failing=False, archived_results_path=None, revision_info=''):
Dirk Pranke 2014/06/17 17:58:58 it feels a bit odd to me that the results object w
patro 2014/07/15 10:36:57 Yes, things can be seperate there need not be any
"""Returns a dictionary containing a summary of the test runs, with the following fields:
'version': a version indicator
'fixable': The number of fixable tests (NOW - PASS)
@@ -306,6 +306,12 @@ def summarize_results(port_obj, expectations, initial_results, retry_results, en
results['build_number'] = port_obj.get_option('build_number')
results['builder_name'] = port_obj.get_option('builder_name')
+ if port_obj.get_option("enable_versioned_results") and archived_results_path:
+ results['previous_results_location'] = archived_results_path
+ results['chromium_revision'] = ''
+ results['blink_revision'] = ''
+
+
try:
# Don't do this by default since it takes >100ms.
# It's only used for uploading data to the flakiness dashboard.

Powered by Google App Engine
This is Rietveld 408576698