Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Tools/Scripts/webkitpy/layout_tests/process_json_data_unittest.py

Issue 339623002: Added support for versioning of layout test results of run-webkit-tests runs (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Tools/Scripts/webkitpy/layout_tests/controllers/manager.py ('K') | « Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py ('k') | Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py » ('j') | Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/layout_tests/process_json_data_unittest.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/process_json_data_unittest.py b/Tools/Scripts/webkitpy/layout_tests/process_json_data_unittest.py
new file mode 100644
index 0000000000000000000000000000000000000000..82dcb6f1256b66b5abcd51f6278df096c8c8677c
--- /dev/null
+++ b/Tools/Scripts/webkitpy/layout_tests/process_json_data_unittest.py
@@ -0,0 +1,216 @@
+# Copyright (C) 2014 Google Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are
+# met:
+#
+# * Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# * Redistributions in binary form must reproduce the above
+# copyright notice, this list of conditions and the following disclaimer
+# in the documentation and/or other materials provided with the
+# distribution.
+# * Neither the name of Google Inc. nor the names of its
+# contributors may be used to endorse or promote products derived from
+# this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import json
+import webkitpy.thirdparty.unittest2 as unittest
+
+from webkitpy.layout_tests.generate_results_dashboard import ProcessJsonData
+
+
+class ProcessJsonDataTester(unittest.TestCase):
+
+ def test_check_failing_results(self):
+ valid_json_data = json.loads('''{
Dirk Pranke 2014/07/29 18:53:06 Nit: is there any particular reason to use json fo
patro 2014/07/30 06:37:45 Done.
+ "tests": {
+ "test_category": {
+ "test_sub_category": {
+ "test_name": {
+ "test.html": {
+ "actual": "TEXT",
+ "expected": "PASS",
+ "is_unexpected": true
+ }
+ }
+ }
+ }
+ }
+ }''')
+ valid_json_data_1 = json.loads('''{
+ "tests": {
+ "test_category": {
+ "test_sub_category": {
+ "test_name": {
+ "test.html": {
+ "actual": "TEXT",
+ "expected": "TEXT",
+ "is_unexpected": true
+ }
+ }
+ }
+ }
+ }
+ }''')
+ valid_json_data_2 = json.loads('''{
+ "tests": {
+ "test_category": {
+ "test_sub_category": {
+ "test_name": {
+ "test.html": {
+ "actual": "TEXT",
+ "expected": "TEXT",
+ "is_unexpected": true
+ }
+ },
+ "test_name_2": {
+ "test_2.html": {
+ "actual": "TEXT",
+ "expected": "PASS",
+ "is_unexpected": true
+ }
+ }
+ }
+ }
+ }
+ }''')
+ expected_result = json.loads('''{
+ "tests": {
+ "test_category": {
+ "test_sub_category": {
+ "test_name": {
+ "test.html": {
+ "archived_results": [
+ "TEXT",
+ "PASS"
+ ]
+ }
+ }
+ }
+ }
+ }
+ }''')
+ process_json_data = ProcessJsonData(valid_json_data, [valid_json_data_1], [valid_json_data_2])
+ actual_result = process_json_data.generate_archived_result()
+ self.assertEqual(expected_result, actual_result)
+
+ def test_check_full_results(self):
+ valid_json_data = json.loads('''{
+ "tests": {
+ "test_category": {
+ "test_sub_category": {
+ "test_name_2": {
+ "test_2.html": {
+ "actual": "TEXT",
+ "expected": "PASS",
+ "is_unexpected": true
+ }
+ }
+ }
+ }
+ }
+ }''')
+ valid_json_data_1 = json.loads('''{
+ "tests": {
+ "test_category": {
+ "test_sub_category": {
+ "test_name": {
+ "test.html": {
+ "actual": "TEXT",
+ "expected": "TEXT",
+ "is_unexpected": true
+ }
+ }
+ }
+ }
+ }
+ }''')
+ valid_json_data_2 = json.loads('''{
+ "tests": {
+ "test_category": {
+ "test_sub_category": {
+ "test_name": {
+ "test.html": {
+ "actual": "TEXT",
+ "expected": "TEXT",
+ "is_unexpected": true
+ }
+ },
+ "test_name_2": {
+ "test_2.html": {
+ "actual": "IMAGE",
+ "expected": "TEXT",
+ "is_unexpected": true
+ }
+ }
+ }
+ }
+ }
+ }''')
+ expected_result = json.loads('''{
+ "tests": {
+ "test_category": {
+ "test_sub_category": {
+ "test_name_2": {
+ "test_2.html": {
+ "archived_results": [
+ "TEXT",
+ "IMAGE"
+ ]
+ }
+ }
+ }
+ }
+ }
+ }''')
+ process_json_data = ProcessJsonData(valid_json_data, [valid_json_data_1], [valid_json_data_2])
+ actual_result = process_json_data.generate_archived_result()
+ self.assertEqual(expected_result, actual_result)
+
+ def test_null_check(self):
+ valid_json_data = json.loads('''{
+ "tests": {
+ "test_category": {
+ "test_sub_category": {
+ "test_name": {
+ "test.html": {
+ "actual": "TEXT",
+ "expected": "PASS",
+ "is_unexpected": true
+ }
+ }
+ }
+ }
+ }
+ }''')
+ expected_result = json.loads('''{
+ "tests": {
+ "test_category": {
+ "test_sub_category": {
+ "test_name": {
+ "test.html": {
+ "archived_results": [
+ "TEXT"
+ ]
+ }
+ }
+ }
+ }
+ }
+ }''')
+ process_json_data = ProcessJsonData(valid_json_data, [], [])
+ actual_result = process_json_data.generate_archived_result()
+ self.assertEqual(expected_result, actual_result)
« Tools/Scripts/webkitpy/layout_tests/controllers/manager.py ('K') | « Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py ('k') | Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py » ('j') | Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698