Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Unified Diff: Source/core/page/CreateWindow.cpp

Issue 339593005: Set the target type when creating the request for main resource (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/CreateWindow.cpp
diff --git a/Source/core/page/CreateWindow.cpp b/Source/core/page/CreateWindow.cpp
index 7289d186c36f91956af366e79087dc7b9b138d54..02c54f851f6ec3b10626475e5994c4c0a0d8e9f3 100644
--- a/Source/core/page/CreateWindow.cpp
+++ b/Source/core/page/CreateWindow.cpp
@@ -153,7 +153,9 @@ LocalFrame* createWindow(const String& urlString, const AtomicString& frameName,
function(newFrame->domWindow(), functionContext);
if (created) {
- FrameLoadRequest request(callingWindow.document(), ResourceRequest(completedURL, referrer));
+ ResourceRequest resourceRequest = ResourceRequest(completedURL, referrer);
+ resourceRequest.initializeForMainResource(newFrame->isMainFrame());
+ FrameLoadRequest request(callingWindow.document(), resourceRequest);
newFrame->loader().load(request);
} else if (!urlString.isEmpty()) {
newFrame->navigationScheduler().scheduleLocationChange(callingWindow.document(), completedURL.string(), referrer, false);
@@ -185,6 +187,7 @@ void createWindowForRequest(const FrameLoadRequest& request, LocalFrame& openerF
newFrame->document()->setReferrerPolicy(openerFrame.document()->referrerPolicy());
}
FrameLoadRequest newRequest(0, request.resourceRequest());
+ newRequest.resourceRequest().initializeForMainResource(newFrame->isMainFrame());
newRequest.setFormState(request.formState());
newFrame->loader().load(newRequest);
}

Powered by Google App Engine
This is Rietveld 408576698