Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 339583003: Do not eliminate bounds checks for "<const> - x". (Closed)

Created:
6 years, 6 months ago by Jarin
Modified:
6 years, 6 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Do not eliminate bounds checks for "<const> - x". Before this change, bounds check elimination treated "<const> - x" as "x - <const>". R=yangguo@chromium.org BUG=385054 TEST=test/mjsunit/regress/regress-385054.js LOG=N Committed: https://code.google.com/p/v8/source/detail?r=21859

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M src/hydrogen-bce.cc View 1 chunk +1 line, -4 lines 0 comments Download
A + test/mjsunit/regress/regress-385054.js View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jarin
6 years, 6 months ago (2014-06-16 13:23:27 UTC) #1
Yang
On 2014/06/16 13:23:27, jarin wrote: lgtm.
6 years, 6 months ago (2014-06-16 13:27:53 UTC) #2
Jarin
6 years, 6 months ago (2014-06-16 13:44:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21859 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698