Wrong pending sheets test causing FOUC.

Wrong pending sheets test causing FOUC.

In r176050, moving the full view repaint from StyleEngine to Document, the
check changed from !hasPendingSheets() to haveStylesheetsLoaded(). The
difference is that m_ignorePendingStylesheets affected the result of the
check which causes a FOUC in named BUG.

BUG=384969
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176367

[rune, 2014-06-16 20:51:17]

I'd like to try to write an automatic test for this since it's not caught by the
current layout tests. The tests in http/tests/ManualTests/fouc are not run.

Please tell if I need to create one before landing (could take some time), or if
we should land this first and I'll try make a test for landing afterwards.

[esprehn, 2014-06-16 21:04:39]

lgtm, I'd prefer a test, but you can land first with a FIXME about it.

[rune, 2014-06-17 11:21:26]

PTAL.

It was not possible to detect the forced repaint through invalidation
rectangles, so I ended up adding an api to Internals to check the document state
for it directly.

[esprehn, 2014-06-17 23:16:56]

I think you might technically want to keep doing setTimeout until
querySelector("link") actually appears otherwise the parser yielding could catch
you. I don't think our parser is ever that aggressive today so I suspect your
test is fine. Lets see if this is ever flaky on the bots, you can probably just
land as is.

lgtm

https://codereview.chromium.org/339573005/diff/20001/LayoutTests/http/tests/f...
File LayoutTests/http/tests/fouc/scroll-left-while-loading.html (right):

https://codereview.chromium.org/339573005/diff/20001/LayoutTests/http/tests/f...
LayoutTests/http/tests/fouc/scroll-left-while-loading.html:19: </script>
This might technically be racing since the parser could yield right after this
<script>, your setTimeout would run without the sheet, and then the parser would
append the <link>.

[esprehn, 2014-06-17 23:18:06]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-06-17 23:18:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rune@opera.com/339573005/20001

[commit-bot: I haz the power, 2014-06-18 00:55:28]

Change committed as 176367