Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1713)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/common/frame_messages.h

Issue 339573003: NavigationTiming: set navigationStart for navigations in new tabs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: DCHECK that browser_navigation_start is always present. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/frame_host/navigator_impl.cc ('K') | « content/browser/frame_host/navigator_impl.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/frame_messages.h
diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h
index 583a1ac81f506efa77de834dbfb03d61cd5a0687..15a93199d51f900cd9d66b346457ceceba47336d 100644
--- a/content/common/frame_messages.h
+++ b/content/common/frame_messages.h
@@ -212,7 +212,9 @@ IPC_STRUCT_BEGIN(FrameMsg_Navigate_Params)
// Type of navigation.
IPC_STRUCT_MEMBER(FrameMsg_Navigate_Type::Value, navigation_type)
- // The time the request was created
+ // The time the request was created. This is used by the old performance
+ // infrastructure to set up DocumentState associated with the RenderView.
+ // TODO(ppi): make it go away.
IPC_STRUCT_MEMBER(base::Time, request_time)
// Extra headers (separated by \n) to send during the request.
@@ -245,7 +247,7 @@ IPC_STRUCT_BEGIN(FrameMsg_Navigate_Params)
// If not empty, which frame to navigate.
IPC_STRUCT_MEMBER(std::string, frame_to_navigate)
- // The navigationStart time to expose to JS for this navigation.
+ // The navigationStart time to expose through the Navigation Timing to JS.
nasko 2014/06/27 23:10:54 nit: Navigation Timing API
ppi 2014/07/01 18:40:13 Done.
IPC_STRUCT_MEMBER(base::TimeTicks, browser_navigation_start)
IPC_STRUCT_END()
« content/browser/frame_host/navigator_impl.cc ('K') | « content/browser/frame_host/navigator_impl.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698