Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: content/common/frame_messages.h

Issue 339573003: NavigationTiming: set navigationStart for navigations in new tabs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update browsertests. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/frame_messages.h
diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h
index d7664b7da34345e05bee13428a51e41d9134731e..ee3a9a29235a6c0e627290331142b0a175a71d73 100644
--- a/content/common/frame_messages.h
+++ b/content/common/frame_messages.h
@@ -209,7 +209,9 @@ IPC_STRUCT_BEGIN(FrameMsg_Navigate_Params)
// Type of navigation.
IPC_STRUCT_MEMBER(FrameMsg_Navigate_Type::Value, navigation_type)
- // The time the request was created
+ // The time the request was created. This is used by the old performance
+ // infrastructure to set up DocumentState associated with the RenderView.
+ // TODO(ppi): make it go away.
IPC_STRUCT_MEMBER(base::Time, request_time)
// Extra headers (separated by \n) to send during the request.
@@ -242,7 +244,7 @@ IPC_STRUCT_BEGIN(FrameMsg_Navigate_Params)
// If not empty, which frame to navigate.
IPC_STRUCT_MEMBER(std::string, frame_to_navigate)
- // The navigationStart time to expose to JS for this navigation.
+ // The navigationStart time to expose through the Navigation Timing API to JS.
IPC_STRUCT_MEMBER(base::TimeTicks, browser_navigation_start)
IPC_STRUCT_END()

Powered by Google App Engine
This is Rietveld 408576698