chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java - Issue 339573002: ContextMenu shows about:blank

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

Issue 339573002: ContextMenu shows about:blank (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed linkurl start check comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

index c79c32375b0efb35435161cc64889f65d7fae140..496e81def3560abef6d80be3a63d260d90c79725 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

@@ -38,7 +38,10 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {

@Override

public void buildContextMenu(ContextMenu menu, Context context, ContextMenuParams params) {

- if (!TextUtils.isEmpty(params.getLinkUrl())) menu.setHeaderTitle(params.getLinkUrl());

+ if (params.isImage() && !TextUtils.isEmpty(params.getSrcUrl()))

+ menu.setHeaderTitle(params.getSrcUrl());

+ else if (!TextUtils.isEmpty(params.getLinkUrl()) )

+ menu.setHeaderTitle(params.getLinkUrl());

if (mMenuInflater == null) mMenuInflater = new MenuInflater(context);

« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »