Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 339563005: cc: cleanup: Remove unnecessary DCHECK (Closed)

Created:
6 years, 6 months ago by hyunki
Modified:
6 years, 6 months ago
Reviewers:
danakj, enne (OOO)
CC:
chromium-reviews, wjmaclean
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

cc: cleanup: Remove unnecessary DCHECK DCHECK(scroll_clip_layer_) is already checked in the beginning of MaxScrollOffset(). R=enne@chromium.org BUG=NONE TEST=NONE(trivial change) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277560

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M cc/layers/layer_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
hyunki
PTAL. Thanks!
6 years, 6 months ago (2014-06-16 12:24:15 UTC) #1
enne (OOO)
Sure? lgtm
6 years, 6 months ago (2014-06-16 17:20:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/339563005/1
6 years, 6 months ago (2014-06-16 17:22:40 UTC) #3
hyunki
On 2014/06/16 17:20:50, enne wrote: > Sure? lgtm Yes. Please see below previous check. 1144 ...
6 years, 6 months ago (2014-06-16 17:56:13 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 22:57:56 UTC) #5
Message was sent while issue was closed.
Change committed as 277560

Powered by Google App Engine
This is Rietveld 408576698