Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 339553004: DevTools: [MediaQueryInspector] Compute media query length on backend (Closed)

Created:
6 years, 6 months ago by lushnikov
Modified:
6 years, 6 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: [MediaQueryInspector] Compute media query length on backend This patch pulls computed media query lengths values from backend. Note: it is ok to create multiple MediaValuesDynamic objects because they don't have any internal state and serve as a helper wrappers. BUG=382996 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M LayoutTests/inspector-protocol/css/css-get-media-queries.html View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/inspector-protocol/css/css-get-media-queries-expected.txt View 4 chunks +7 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
lushnikov
ptal
6 years, 6 months ago (2014-06-18 12:53:23 UTC) #1
pfeldman
lgtm
6 years, 6 months ago (2014-06-18 14:38:16 UTC) #2
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 6 months ago (2014-06-18 14:42:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/339553004/1
6 years, 6 months ago (2014-06-18 14:42:54 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 16:48:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/12638)
6 years, 6 months ago (2014-06-18 16:48:50 UTC) #6
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 6 months ago (2014-06-18 18:29:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/339553004/1
6 years, 6 months ago (2014-06-18 18:30:54 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 19:36:47 UTC) #9
Message was sent while issue was closed.
Change committed as 176445

Powered by Google App Engine
This is Rietveld 408576698