Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 339553003: Disable one screen orientation layout tests to enable design changes. (Closed)

Created:
6 years, 6 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Disable one screen orientation layout tests to enable design changes. The mock is currently assuming that the screen orientation is handled by a RendererWebKitPlatformSupportImpl which is no longer the case. It will move to be part of WebFrameTestProxy but that will require a two sided patch so we should first disable the false-negative. BUG=162827 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176203

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M LayoutTests/screen_orientation/lockOrientation-sandboxed-iframe.html View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
mlamouri (slow - plz ping)
6 years, 6 months ago (2014-06-16 10:54:35 UTC) #1
Michael van Ouwerkerk
lgtm https://codereview.chromium.org/339553003/diff/1/LayoutTests/screen_orientation/lockOrientation-sandboxed-iframe.html File LayoutTests/screen_orientation/lockOrientation-sandboxed-iframe.html (right): https://codereview.chromium.org/339553003/diff/1/LayoutTests/screen_orientation/lockOrientation-sandboxed-iframe.html#newcode18 LayoutTests/screen_orientation/lockOrientation-sandboxed-iframe.html:18: // FIXME: re-enable when better mock screen orientation ...
6 years, 6 months ago (2014-06-16 11:02:12 UTC) #2
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-06-16 11:08:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/339553003/20001
6 years, 6 months ago (2014-06-16 11:09:04 UTC) #4
mlamouri (slow - plz ping)
Thanks! https://codereview.chromium.org/339553003/diff/1/LayoutTests/screen_orientation/lockOrientation-sandboxed-iframe.html File LayoutTests/screen_orientation/lockOrientation-sandboxed-iframe.html (right): https://codereview.chromium.org/339553003/diff/1/LayoutTests/screen_orientation/lockOrientation-sandboxed-iframe.html#newcode18 LayoutTests/screen_orientation/lockOrientation-sandboxed-iframe.html:18: // FIXME: re-enable when better mock screen orientation ...
6 years, 6 months ago (2014-06-16 11:09:16 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 12:13:38 UTC) #6
Message was sent while issue was closed.
Change committed as 176203

Powered by Google App Engine
This is Rietveld 408576698