Move divider detection and creation onto TimelineUIUtils instance

Source/devtools/front_end/timeline/TimelineUIUtils.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 43 matching lines @@
     /**
      * @param {string} recordType
      * @return {boolean}
      */
     isCoalescable: function(recordType)
     {
         throw new Error("Not implemented.");
     },
     /**
      * @param {!WebInspector.TimelineModel.Record} record
+     * @return {boolean}
+     */
+    isEventDivider: function(record)
+    {
+        throw new Error("Not implemented.");
+    },
+    /**
+     * @param {!WebInspector.TimelineModel.Record} record
      * @return {?Object}
      */
     countersForRecord: function(record)
     {
         throw new Error("Not implemented.");
     },
     /**
      * @param {!WebInspector.TimelineModel.Record} record
      * @return {?Object}
      */
@@ skipping 14 matching lines @@
     /**
      * @param {!WebInspector.TimelineModel.Record} record
      * @param {!WebInspector.TimelineModel} model
      * @param {!WebInspector.Linkifier} linkifier
      * @param {function(!DocumentFragment)} callback
      * @param {boolean} loadedFromFile
      */
     generateDetailsContent: function(record, model, linkifier, callback, loadedFromFile)
     {
         throw new Error("Not implemented.");
+    },
+    /**
+     * @param {string} recordType
+     * @param {string=} title
+     * @return {!Element}
+     */
+    createEventDivider: function(recordType, title)
+    {
+        throw new Error("Not implemented.");
     }
 }
 
 /**
  * @return {!Object.<string, !WebInspector.TimelineCategory>}
  */
 WebInspector.TimelineUIUtils.categories = function()
 {
     if (WebInspector.TimelineUIUtils._categories)
         return WebInspector.TimelineUIUtils._categories;
@@ skipping 81 matching lines @@
         result = {
             title: WebInspector.UIString("Unknown: %s", type),
             category: WebInspector.TimelineUIUtils.categories()["other"]
         };
         recordStyles[type] = result;
     }
     return result;
 }
 
 /**
- * @param {!WebInspector.TimelineModel.Record} record
- * @return {boolean}
- */
-WebInspector.TimelineUIUtils.isEventDivider = function(record)
-{
-    var recordTypes = WebInspector.TimelineModel.RecordType;
-    if (record.type() === recordTypes.TimeStamp)
-        return true;
-    if (record.type() === recordTypes.MarkFirstPaint)
-        return true;
-    if (record.type() === recordTypes.MarkDOMContent || record.type() === recordTypes.MarkLoad)
-        return record.data()["isMainFrame"];
-    return false;
-}
-
-/**
  * @param {string=} recordType
  * @return {boolean}
  */
 WebInspector.TimelineUIUtils.needsPreviewElement = function(recordType)
 {
     if (!recordType)
         return false;
     const recordTypes = WebInspector.TimelineModel.RecordType;
     switch (recordType) {
     case recordTypes.ResourceSendRequest:
     case recordTypes.ResourceReceiveResponse:
     case recordTypes.ResourceReceivedData:
     case recordTypes.ResourceFinish:
         return true;
     default:
         return false;
     }
 }
 
 /**
- * @param {string} recordType
- * @param {string=} title
- * @return {!Element}
- */
-WebInspector.TimelineUIUtils.createEventDivider = function(recordType, title)
-{
-    var eventDivider = document.createElement("div");
-    eventDivider.className = "resources-event-divider";
-    var recordTypes = WebInspector.TimelineModel.RecordType;
-
-    if (recordType === recordTypes.MarkDOMContent)
-        eventDivider.className += " resources-blue-divider";
-    else if (recordType === recordTypes.MarkLoad)
-        eventDivider.className += " resources-red-divider";
-    else if (recordType === recordTypes.MarkFirstPaint)
-        eventDivider.className += " resources-green-divider";
-    else if (recordType === recordTypes.TimeStamp)
-        eventDivider.className += " resources-orange-divider";
-    else if (recordType === recordTypes.BeginFrame)
-        eventDivider.className += " timeline-frame-divider";
-
-    if (title)
-        eventDivider.title = title;
-
-    return eventDivider;
-}
-
-
-/**
  * @param {!WebInspector.TimelineModel} model
  * @param {!{name: string, tasks: !Array.<!{startTime: number, endTime: number}>, firstTaskIndex: number, lastTaskIndex: number}} info
  * @return {!Element}
  */
 WebInspector.TimelineUIUtils.generateMainThreadBarPopupContent = function(model, info)
 {
     var firstTaskIndex = info.firstTaskIndex;
     var lastTaskIndex = info.lastTaskIndex;
     var tasks = info.tasks;
     var messageCount = lastTaskIndex - firstTaskIndex + 1;
@@ skipping 21 matching lines @@
  * @param {!WebInspector.TimelineModel} model
  * @return {string}
  */
 WebInspector.TimelineUIUtils.recordTitle = function(record, model)
 {
     var recordData = record.data();
     if (record.type() === WebInspector.TimelineModel.RecordType.TimeStamp)
         return recordData["message"];
     if (record.type() === WebInspector.TimelineModel.RecordType.JSFrame)
         return recordData["functionName"];
-    if (WebInspector.TimelineUIUtils.isEventDivider(record)) {
+    if (WebInspector.TimelineUIUtilsImpl.isEventDivider(record)) {
         var startTime = Number.millisToString(record.startTime() - model.minimumRecordTime());
         return WebInspector.UIString("%s at %s", WebInspector.TimelineUIUtils.recordStyle(record).title, startTime, true);
     }
     return WebInspector.TimelineUIUtils.recordStyle(record).title;
 }
 
 /**
  * @param {!Object} total
  * @param {!Object} addend
  */
@@ skipping 372 matching lines @@
         for (var i = 0; i < stackTrace.length; ++i) {
             var stackFrame = stackTrace[i];
             var row = stackTraceElement.createChild("div");
             row.createTextChild(stackFrame.functionName || WebInspector.UIString("(anonymous function)"));
             row.createTextChild(" @ ");
             var urlElement = this._linkifier.linkifyLocation(this._target, stackFrame.url, stackFrame.lineNumber - 1);
             row.appendChild(urlElement);
         }
     }
 }