Componentize URLDatabase

Componentize URLDatabase

Move chrome/browser/history/url_database.{cc,h} to components/history/core/browser.

From chrome/browser/history/history_types.{cc,h}:
- Move URLID, URLRow and URLResult to url_row.{cc,h}
- Move KeywordSearchTermVisit and KeywordSearchTermRow to keyword_search_term.{cc,h}
- Move autocomplete threshold related stuff (kLowQualityMatch* constants and two threshold related functions) to url_databse.{cc,h}

BUG=387284
TEST=git cl try
TBR=sky@chromium.org for include fix under chrome/browser
TBR=mmenke@chrmoium.org as an owner of net, a new dependency added to components/history/DEPS
TBR=blundell@chromium.org as an owner of components/history.gypi

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279859

[hashimoto, 2014-06-25 04:52:27]

Sylvain, could you review this change as an owner of history?

git-cl did a nice job for almost all A+ files.
The exceptions are keyword_search_term.{cc,h} which are also made by moving
lines from history_types.{cc,h}, but shown as a copy of a wrong file.

[sdefresne, 2014-06-25 13:21:09]

LGTM with comments

https://codereview.chromium.org/339433007/diff/140001/components/history.gypi
File components/history.gypi (right):

https://codereview.chromium.org/339433007/diff/140001/components/history.gypi...
components/history.gypi:16: 'keyed_service_core',
You need to add net/net.gyp:net as dependency here too.

https://codereview.chromium.org/339433007/diff/140001/components/history/core...
File components/history/core/browser/keyword_search_term.h (right):

https://codereview.chromium.org/339433007/diff/140001/components/history/core...
components/history/core/browser/keyword_search_term.h:21: base::string16 term;  
 // The search term that was used.
nit: either align all the comments, or use two-spaces everywhere.

[sdefresne, 2014-06-25 13:21:41]

+blundell as I'm not an OWNER of history

[hashimoto, 2014-06-25 16:37:33]

https://codereview.chromium.org/339433007/diff/140001/components/history.gypi
File components/history.gypi (right):

https://codereview.chromium.org/339433007/diff/140001/components/history.gypi...
components/history.gypi:16: 'keyed_service_core',
On 2014/06/25 13:21:09, sdefresne wrote:
> You need to add net/net.gyp:net as dependency here too.

Good catch.
Added net and query_parser.

https://codereview.chromium.org/339433007/diff/140001/components/history/core...
File components/history/core/browser/keyword_search_term.h (right):

https://codereview.chromium.org/339433007/diff/140001/components/history/core...
components/history/core/browser/keyword_search_term.h:21: base::string16 term;  
 // The search term that was used.
On 2014/06/25 13:21:09, sdefresne wrote:
> nit: either align all the comments, or use two-spaces everywhere.

Now using two-spaces everywhere.

[hashimoto, 2014-06-25 16:37:56]

Colin, could you take a look at this change?

[sdefresne, 2014-06-25 16:58:48]

-blundell, +droger for OWNERS of history

[droger, 2014-06-25 17:04:23]

lgtm

[hashimoto, 2014-06-25 17:39:50]

TBRing a number of people:
- sky@chromium.org for include fix under chrome/browser
- mmenke@chrmoium.org as an owner of net, a new dependency added to
components/history/DEPS
- blundell@chromium.org as an owner of components/history.gypi (btw why
components/OWNERS doesn't have "per-file" lines for history.gypi?)

[hashimoto, 2014-06-25 17:40:07]

The CQ bit was checked by hashimoto@chromium.org

[sdefresne, 2014-06-25 17:41:03]

On 2014/06/25 17:39:50, hashimoto wrote:
> TBRing a number of people:
> - mailto:sky@chromium.org for include fix under chrome/browser
> - mailto:mmenke@chrmoium.org as an owner of net, a new dependency added to
> components/history/DEPS
> - mailto:blundell@chromium.org as an owner of components/history.gypi (btw why
> components/OWNERS doesn't have "per-file" lines for history.gypi?)

components/history.gypi: I just forgot to add it

[commit-bot: I haz the power, 2014-06-25 17:41:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/339433007/180001

[commit-bot: I haz the power, 2014-06-25 20:01:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-06-25 20:05:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-25 20:05:58]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[hashimoto, 2014-06-25 20:39:44]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-06-25 20:42:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/339433007/200001

[commit-bot: I haz the power, 2014-06-25 23:45:40]

Change committed as 279859

[hashimoto, 2014-06-26 00:52:44]

On 2014/06/25 17:41:03, sdefresne wrote:
> On 2014/06/25 17:39:50, hashimoto wrote:
> > TBRing a number of people:
> > - mailto:sky@chromium.org for include fix under chrome/browser
> > - mailto:mmenke@chrmoium.org as an owner of net, a new dependency added to
> > components/history/DEPS
> > - mailto:blundell@chromium.org as an owner of components/history.gypi (btw
why
> > components/OWNERS doesn't have "per-file" lines for history.gypi?)
> 
> components/history.gypi: I just forgot to add it

I see.
Made a CL to add them. https://codereview.chromium.org/356543005/