Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 339413002: Use the managed bookmarks icon for its folder on Mac. (Closed)

Created:
6 years, 6 months ago by Joao da Silva
Modified:
6 years, 6 months ago
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Use the managed bookmarks icon for its folder on Mac. BUG=379862 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278661

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
M chrome/app/theme/theme_resources.grd View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm View 4 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Joao da Silva
PTAL @asvitkine: this CL just sets the icon for the managed bookmarks folder in the ...
6 years, 6 months ago (2014-06-18 19:54:51 UTC) #1
Alexei Svitkine (slow)
lgtm
6 years, 6 months ago (2014-06-18 20:34:32 UTC) #2
Joao da Silva
@oshima: ping :-)
6 years, 6 months ago (2014-06-19 20:42:56 UTC) #3
oshima
c/a/theme lgtm
6 years, 6 months ago (2014-06-19 20:52:26 UTC) #4
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 6 months ago (2014-06-19 22:28:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/339413002/20001
6 years, 6 months ago (2014-06-19 22:30:50 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 03:44:16 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 10:17:06 UTC) #8
Message was sent while issue was closed.
Change committed as 278661

Powered by Google App Engine
This is Rietveld 408576698