Issue 339403004: Fix RTL issues with the chrome://devices page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339403004: Fix RTL issues with the chrome://devices page (Closed)

Created:
6 years, 6 months ago by Noam Samuel

Modified:
6 years, 6 months ago

Reviewers:
Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix RTL issues with the chrome://devices page 1. Make the chrome://devices issue run right to left for RTL languages 2. Make the chrome://devices page show icons correctly when displayed right to left 3. Remove unnecessary comment about needing i18n BUG=386020 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278328

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome/browser/resources/local_discovery/local_discovery.css	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	chrome/browser/resources/local_discovery/local_discovery.html	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/339403004/1

6 years, 6 months ago (2014-06-19 00:45:02 UTC) #3

Message was sent while issue was closed.

Change committed as 278328

Expand Messages | Collapse Messages