Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 339363002: Fix invalid syntax for JS setters in tests (Closed)

Created:
6 years, 6 months ago by arv (Not doing code reviews)
Modified:
6 years, 6 months ago
Reviewers:
esprehn, yurys
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Fix invalid syntax for JS setters in tests ECMAScript setters require exactly one parameter. We had a bunch of tests with zero parameters which is not valid and should have been SyntaxErrors in the first place. BUG=383596 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176451

Patch Set 1 #

Messages

Total messages: 8 (0 generated)
arv (Not doing code reviews)
6 years, 6 months ago (2014-06-18 17:02:10 UTC) #1
esprehn
Can you explain the description why you had to add all these _ variables? Why ...
6 years, 6 months ago (2014-06-18 17:59:37 UTC) #2
arv (Not doing code reviews)
On 2014/06/18 17:59:37, esprehn wrote: > Can you explain the description why you had to ...
6 years, 6 months ago (2014-06-18 18:04:46 UTC) #3
esprehn
On 2014/06/18 at 18:04:46, arv wrote: > On 2014/06/18 17:59:37, esprehn wrote: > > Can ...
6 years, 6 months ago (2014-06-18 18:10:20 UTC) #4
arv (Not doing code reviews)
On 2014/06/18 18:10:20, esprehn wrote: > On 2014/06/18 at 18:04:46, arv wrote: > > On ...
6 years, 6 months ago (2014-06-18 18:13:05 UTC) #5
arv (Not doing code reviews)
The CQ bit was checked by arv@chromium.org
6 years, 6 months ago (2014-06-18 18:13:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/339363002/1
6 years, 6 months ago (2014-06-18 18:13:51 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 20:20:47 UTC) #8
Message was sent while issue was closed.
Change committed as 176451

Powered by Google App Engine
This is Rietveld 408576698