Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 339343003: Cleanup Blink's Platform from Screen Orientation stuff. (Closed)

Created:
6 years, 6 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 6 months ago
Reviewers:
tkent, abarth-chromium
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Cleanup Blink's Platform from Screen Orientation stuff. The embedders should now use WebScreenOrientationClient instead. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -48 lines) Patch
M Source/modules/screen_orientation/ScreenOrientationController.cpp View 3 chunks +0 lines, -5 lines 0 comments Download
M public/platform/Platform.h View 3 chunks +0 lines, -21 lines 0 comments Download
D public/platform/WebScreenOrientationListener.h View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mlamouri (slow - plz ping)
Kent-san, can you have a look at this please? :)
6 years, 6 months ago (2014-06-18 10:51:22 UTC) #1
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-18 23:34:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/339343003/1
6 years, 6 months ago (2014-06-18 23:35:50 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 23:38:53 UTC) #4
Message was sent while issue was closed.
Change committed as 176462

Powered by Google App Engine
This is Rietveld 408576698