Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 339273002: add google IO byte video to kiosk app page (Closed)

Created:
6 years, 6 months ago by smain
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

add google IO byte video to kiosk app page BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277983

Patch Set 1 #

Patch Set 2 : enable video title bar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/common/extensions/docs/templates/articles/manifest/kiosk_enabled.html View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
smain
The CQ bit was checked by smain@chromium.org
6 years, 6 months ago (2014-06-18 00:16:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/smain@chromium.org/339273002/20001
6 years, 6 months ago (2014-06-18 00:18:02 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 00:18:02 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-18 00:18:03 UTC) #4
mkearney1
lgtm
6 years, 6 months ago (2014-06-18 00:27:08 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 00:29:06 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-18 00:29:07 UTC) #7
mkearney1
Ben-- just added you as a reviewer. I already lgtm'd. Just need a committer. Maybe ...
6 years, 6 months ago (2014-06-18 00:44:31 UTC) #8
not at google - send to devlin
lgtm. meggin ping me about this tomorrow.
6 years, 6 months ago (2014-06-18 00:45:06 UTC) #9
smain
The CQ bit was checked by smain@chromium.org
6 years, 6 months ago (2014-06-18 02:32:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/smain@chromium.org/339273002/20001
6 years, 6 months ago (2014-06-18 02:33:06 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 08:25:20 UTC) #12
Message was sent while issue was closed.
Change committed as 277983

Powered by Google App Engine
This is Rietveld 408576698