Issue 339263002: Add Linux breakpad targets and gtest_main to GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339263002: Add Linux breakpad targets and gtest_main to GN build. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
jamesr

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add Linux breakpad targets and gtest_main to GN build. I only tested this on Linux. Some of the other platforms still have TODOs and parts missing. We can fill these out when they're required. BUG= R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278157

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+648 lines, -0 lines)			Patch
M	BUILD.gn	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
A	breakpad/BUILD.gn	View	1 2 3	1 chunk	+639 lines, -0 lines	0 comments	Download
M	tools/gn/secondary/testing/gtest/BUILD.gn	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm https://codereview.chromium.org/339263002/diff/60001/breakpad/BUILD.gn File breakpad/BUILD.gn (right): https://codereview.chromium.org/339263002/diff/60001/breakpad/BUILD.gn#newcode11 breakpad/BUILD.gn:11: cflags = [ "-Wno-tautological-constant-out-of-range-compare" ] that's alarming https://codereview.chromium.org/339263002/diff/60001/tools/gn/secondary/testing/gtest/BUILD.gn ...

6 years, 6 months ago (2014-06-18 18:40:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as r278157.

Expand Messages | Collapse Messages