Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: ppapi/nacl_irt/manifest_service.cc

Issue 339213003: Pepper: Simplify OpenResource() for Non-SFI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/nacl_irt/manifest_service.cc
diff --git a/ppapi/nacl_irt/manifest_service.cc b/ppapi/nacl_irt/manifest_service.cc
index 85b7fae2c960c9ca5ca156abf3213b9deed1524a..a3cf1c6b5ffe49ec24159921913322874695fc32 100644
--- a/ppapi/nacl_irt/manifest_service.cc
+++ b/ppapi/nacl_irt/manifest_service.cc
@@ -37,12 +37,9 @@ void ManifestService::StartupInitializationComplete() {
}
bool ManifestService::OpenResource(const char* file, int* fd) {
- // OpenResource will return INVALID SerializedHandle, if it is not supported.
- // Specifically, PNaCl doesn't support open resource.
ppapi::proxy::SerializedHandle ipc_fd;
if (!filter_->Send(new PpapiHostMsg_OpenResource(
- std::string(kFilePrefix) + file, &ipc_fd)) ||
- !ipc_fd.is_file()) {
hidehiko 2014/06/18 04:43:11 Why this is removed?
teravest 2014/06/18 20:13:44 That's some carryover from debugging. Restored.
+ std::string(kFilePrefix) + file, &ipc_fd))) {
LOG(ERROR) << "ManifestService::OpenResource failed:" << file;
*fd = -1;
return false;

Powered by Google App Engine
This is Rietveld 408576698