Issue 339193002: Silence warnings about using offsetof on near-POD structs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339193002: Silence warnings about using offsetof on near-POD structs. (Closed)

Created:
6 years, 6 months ago by mtklein_C

Modified:
6 years, 6 months ago

Reviewers:
bungeman-skia, mtklein, reed1

CC:
reviews_skia.org, t.thornton6_gmail.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Silence warnings about using offsetof on near-POD structs. This is coming up with SkMatrix, which is POD according to GCC >= 4.6 but not before (specifically, not at GCC 4.4). BUG=skia: Committed: https://skia.googlesource.com/skia/+/24ad0965404c0bc978f27db27e2f00ebac95239c

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	gyp/common_conditions.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

mtklein

+Ben. Was thinking this was in include somehow... Any CL will do!

6 years, 6 months ago (2014-06-17 18:25:26 UTC) #2

mtklein

On 2014/06/17 18:25:26, mtklein wrote: > +Ben. Was thinking this was in include somehow... Any ...

6 years, 6 months ago (2014-06-17 18:25:59 UTC) #3

mtklein

On 2014/06/17 18:25:59, mtklein wrote: > On 2014/06/17 18:25:26, mtklein wrote: > > +Ben. Was ...

6 years, 6 months ago (2014-06-17 18:26:34 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/339193002/1

6 years, 6 months ago (2014-06-17 18:27:47 UTC) #6

commit-bot: I haz the power

6 years, 6 months ago (2014-06-17 18:47:44 UTC) #7

Message was sent while issue was closed.

Change committed as 24ad0965404c0bc978f27db27e2f00ebac95239c