Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: runtime/vm/runtime_entry_mips.cc

Issue 339183010: Specialize breakpoint stubs by set of live registers of the stubs they are intercepting. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/runtime_entry_mips.cc
diff --git a/runtime/vm/runtime_entry_mips.cc b/runtime/vm/runtime_entry_mips.cc
index b57112a89a8a763226a0476513ef545fce72289b..76a3bcbd9723a80bfcb87b9141df163c43ed5d7a 100644
--- a/runtime/vm/runtime_entry_mips.cc
+++ b/runtime/vm/runtime_entry_mips.cc
@@ -20,7 +20,7 @@ namespace dart {
// function. Input for the stub is as follows:
// SP : points to the arguments and return value array.
// S5 : address of the runtime function to call.
-// S4 : number of arguments to the call as Smi.
+// S4 : number of arguments to the call.
void RuntimeEntry::Call(Assembler* assembler, intptr_t argument_count) const {
// Compute the effective address. When running under the simulator,
// this is a redirection address that forces the simulator to call
@@ -47,8 +47,9 @@ void RuntimeEntry::Call(Assembler* assembler, intptr_t argument_count) const {
} else {
// Argument count is not checked here, but in the runtime entry for a more
// informative error message.
+ ASSERT((entry & kSmiTagMask) == 0);
__ LoadImmediate(S5, entry);
- __ LoadImmediate(S4, Smi::RawValue(argument_count));
+ __ LoadImmediate(S4, argument_count);
__ BranchLink(&StubCode::CallToRuntimeLabel());
}
}

Powered by Google App Engine
This is Rietveld 408576698