Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: runtime/vm/assembler_x64.cc

Issue 339183010: Specialize breakpoint stubs by set of live registers of the stubs they are intercepting. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_x64.cc
diff --git a/runtime/vm/assembler_x64.cc b/runtime/vm/assembler_x64.cc
index f15fab1cda5cf4bd45915ac75b7a6a8a1f38ec37..93ba4116eae07d90ee3fa0053647da47dceb275f 100644
--- a/runtime/vm/assembler_x64.cc
+++ b/runtime/vm/assembler_x64.cc
@@ -62,11 +62,30 @@ Assembler::Assembler(bool use_far_branches)
patchable_pool_entries_.Add(kNotPatchable);
}
- // Create fixed object pool entry for debugger stub.
- if (StubCode::BreakpointRuntime_entry() != NULL) {
+ // Create fixed object pool entries for debugger stubs.
+ if (StubCode::ICCallBreakpoint_entry() != NULL) {
intptr_t index =
- FindExternalLabel(&StubCode::BreakpointRuntimeLabel(), kNotPatchable);
- ASSERT(index == kBreakpointRuntimeCPIndex);
+ FindExternalLabel(&StubCode::ICCallBreakpointLabel(),
+ kNotPatchable);
+ ASSERT(index == kICCallBreakpointCPIndex);
+ } else {
+ object_pool_.Add(vacant, Heap::kOld);
+ patchable_pool_entries_.Add(kNotPatchable);
+ }
+ if (StubCode::ClosureCallBreakpoint_entry() != NULL) {
+ intptr_t index =
+ FindExternalLabel(&StubCode::ClosureCallBreakpointLabel(),
+ kNotPatchable);
+ ASSERT(index == kClosureCallBreakpointCPIndex);
+ } else {
+ object_pool_.Add(vacant, Heap::kOld);
+ patchable_pool_entries_.Add(kNotPatchable);
+ }
+ if (StubCode::RuntimeCallBreakpoint_entry() != NULL) {
+ intptr_t index =
+ FindExternalLabel(&StubCode::RuntimeCallBreakpointLabel(),
+ kNotPatchable);
+ ASSERT(index == kRuntimeCallBreakpointCPIndex);
} else {
object_pool_.Add(vacant, Heap::kOld);
patchable_pool_entries_.Add(kNotPatchable);

Powered by Google App Engine
This is Rietveld 408576698