Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 339183010: Specialize breakpoint stubs by set of live registers of the stubs they are intercepting. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_ia32.cc
diff --git a/runtime/vm/flow_graph_compiler_ia32.cc b/runtime/vm/flow_graph_compiler_ia32.cc
index 3e7f69f3377250b2787f664198c16313f5e61933..22fca27c60eaf3d835bf44a167e53248e93a7ef2 100644
--- a/runtime/vm/flow_graph_compiler_ia32.cc
+++ b/runtime/vm/flow_graph_compiler_ia32.cc
@@ -1188,7 +1188,6 @@ void FlowGraphCompiler::EmitUnoptimizedStaticCall(
UNIMPLEMENTED();
}
ExternalLabel target_label(label_address);
- __ movl(EDX, Immediate(0));
__ LoadObject(ECX, ic_data);
GenerateDartCall(deopt_id,
token_pos,
@@ -1197,6 +1196,7 @@ void FlowGraphCompiler::EmitUnoptimizedStaticCall(
locs);
__ Drop(argument_count);
#if defined(DEBUG)
+ __ movl(ECX, Immediate(kInvalidObjectPointer));
__ movl(EDX, Immediate(kInvalidObjectPointer));
#endif
}
@@ -1249,7 +1249,6 @@ void FlowGraphCompiler::EmitInstanceCall(ExternalLabel* target_label,
intptr_t token_pos,
LocationSummary* locs) {
ASSERT(Array::Handle(ic_data.arguments_descriptor()).Length() > 0);
- __ movl(EDX, Immediate(0));
__ LoadObject(ECX, ic_data);
GenerateDartCall(deopt_id,
token_pos,
@@ -1393,8 +1392,6 @@ void FlowGraphCompiler::EmitEqualityRegRegCompare(Register left,
if (is_optimizing()) {
__ call(&stub_code->OptimizedIdenticalWithNumberCheckLabel());
} else {
- __ movl(EDX, Immediate(0));
- __ movl(ECX, Immediate(0));
__ call(&stub_code->UnoptimizedIdenticalWithNumberCheckLabel());
}
if (token_pos != Scanner::kNoSourcePos) {
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698