Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: runtime/vm/debugger_arm.cc

Issue 339183010: Specialize breakpoint stubs by set of live registers of the stubs they are intercepting. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | runtime/vm/debugger_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger_arm.cc
diff --git a/runtime/vm/debugger_arm.cc b/runtime/vm/debugger_arm.cc
index 65458fa256b0a286b468c25e3c82391a9ee4497a..3be4d1ecd79187e174617d874d07d4c023266fcc 100644
--- a/runtime/vm/debugger_arm.cc
+++ b/runtime/vm/debugger_arm.cc
@@ -46,12 +46,22 @@ void CodeBreakpoint::PatchCode() {
WritableInstructionsScope writable(instrs.EntryPoint(), instrs.size());
switch (breakpoint_kind_) {
case RawPcDescriptors::kIcCall:
- case RawPcDescriptors::kUnoptStaticCall:
- case RawPcDescriptors::kRuntimeCall:
+ case RawPcDescriptors::kUnoptStaticCall: {
+ saved_value_ = CodePatcher::GetStaticCallTargetAt(pc_, code);
+ CodePatcher::PatchStaticCallAt(
+ pc_, code, StubCode::ICCallBreakpointEntryPoint());
+ break;
+ }
case RawPcDescriptors::kClosureCall: {
saved_value_ = CodePatcher::GetStaticCallTargetAt(pc_, code);
- CodePatcher::PatchStaticCallAt(pc_, code,
- StubCode::BreakpointRuntimeEntryPoint());
+ CodePatcher::PatchStaticCallAt(
+ pc_, code, StubCode::ClosureCallBreakpointEntryPoint());
+ break;
+ }
+ case RawPcDescriptors::kRuntimeCall: {
+ saved_value_ = CodePatcher::GetStaticCallTargetAt(pc_, code);
+ CodePatcher::PatchStaticCallAt(
+ pc_, code, StubCode::RuntimeCallBreakpointEntryPoint());
break;
}
default:
« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | runtime/vm/debugger_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698