Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: runtime/vm/assembler_x64.cc

Issue 339183010: Specialize breakpoint stubs by set of live registers of the stubs they are intercepting. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/cpu.h" 9 #include "vm/cpu.h"
10 #include "vm/heap.h" 10 #include "vm/heap.h"
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 patchable_pool_entries_.Add(kNotPatchable); 55 patchable_pool_entries_.Add(kNotPatchable);
56 } 56 }
57 57
58 if (StubCode::CallToRuntime_entry() != NULL) { 58 if (StubCode::CallToRuntime_entry() != NULL) {
59 FindExternalLabel(&StubCode::CallToRuntimeLabel(), kNotPatchable); 59 FindExternalLabel(&StubCode::CallToRuntimeLabel(), kNotPatchable);
60 } else { 60 } else {
61 object_pool_.Add(vacant, Heap::kOld); 61 object_pool_.Add(vacant, Heap::kOld);
62 patchable_pool_entries_.Add(kNotPatchable); 62 patchable_pool_entries_.Add(kNotPatchable);
63 } 63 }
64 64
65 // Create fixed object pool entry for debugger stub. 65 // Create fixed object pool entries for debugger stubs.
66 if (StubCode::BreakpointRuntime_entry() != NULL) { 66 if (StubCode::ICCallBreakpoint_entry() != NULL) {
67 intptr_t index = 67 intptr_t index =
68 FindExternalLabel(&StubCode::BreakpointRuntimeLabel(), kNotPatchable); 68 FindExternalLabel(&StubCode::ICCallBreakpointLabel(),
69 ASSERT(index == kBreakpointRuntimeCPIndex); 69 kNotPatchable);
70 ASSERT(index == kICCallBreakpointCPIndex);
70 } else { 71 } else {
71 object_pool_.Add(vacant, Heap::kOld); 72 object_pool_.Add(vacant, Heap::kOld);
72 patchable_pool_entries_.Add(kNotPatchable); 73 patchable_pool_entries_.Add(kNotPatchable);
74 }
75 if (StubCode::ClosureCallBreakpoint_entry() != NULL) {
76 intptr_t index =
77 FindExternalLabel(&StubCode::ClosureCallBreakpointLabel(),
78 kNotPatchable);
79 ASSERT(index == kClosureCallBreakpointCPIndex);
80 } else {
81 object_pool_.Add(vacant, Heap::kOld);
82 patchable_pool_entries_.Add(kNotPatchable);
83 }
84 if (StubCode::RuntimeCallBreakpoint_entry() != NULL) {
85 intptr_t index =
86 FindExternalLabel(&StubCode::RuntimeCallBreakpointLabel(),
87 kNotPatchable);
88 ASSERT(index == kRuntimeCallBreakpointCPIndex);
89 } else {
90 object_pool_.Add(vacant, Heap::kOld);
91 patchable_pool_entries_.Add(kNotPatchable);
73 } 92 }
74 } 93 }
75 } 94 }
76 95
77 96
78 void Assembler::InitializeMemoryWithBreakpoints(uword data, intptr_t length) { 97 void Assembler::InitializeMemoryWithBreakpoints(uword data, intptr_t length) {
79 memset(reinterpret_cast<void*>(data), Instr::kBreakPointInstruction, length); 98 memset(reinterpret_cast<void*>(data), Instr::kBreakPointInstruction, length);
80 } 99 }
81 100
82 101
(...skipping 3277 matching lines...) Expand 10 before | Expand all | Expand 10 after
3360 3379
3361 3380
3362 const char* Assembler::FpuRegisterName(FpuRegister reg) { 3381 const char* Assembler::FpuRegisterName(FpuRegister reg) {
3363 ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters)); 3382 ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters));
3364 return xmm_reg_names[reg]; 3383 return xmm_reg_names[reg];
3365 } 3384 }
3366 3385
3367 } // namespace dart 3386 } // namespace dart
3368 3387
3369 #endif // defined TARGET_ARCH_X64 3388 #endif // defined TARGET_ARCH_X64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698