Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: runtime/vm/assembler_arm64.cc

Issue 339183010: Specialize breakpoint stubs by set of live registers of the stubs they are intercepting. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/cpu.h" 9 #include "vm/cpu.h"
10 #include "vm/longjump.h" 10 #include "vm/longjump.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 patchable_pool_entries_.Add(kNotPatchable); 59 patchable_pool_entries_.Add(kNotPatchable);
60 } 60 }
61 61
62 if (StubCode::CallToRuntime_entry() != NULL) { 62 if (StubCode::CallToRuntime_entry() != NULL) {
63 FindExternalLabel(&StubCode::CallToRuntimeLabel(), kNotPatchable); 63 FindExternalLabel(&StubCode::CallToRuntimeLabel(), kNotPatchable);
64 } else { 64 } else {
65 object_pool_.Add(vacant, Heap::kOld); 65 object_pool_.Add(vacant, Heap::kOld);
66 patchable_pool_entries_.Add(kNotPatchable); 66 patchable_pool_entries_.Add(kNotPatchable);
67 } 67 }
68 68
69 // Create fixed object pool entry for debugger stub. 69 // Create fixed object pool entries for debugger stubs.
70 if (StubCode::BreakpointRuntime_entry() != NULL) { 70 if (StubCode::ICCallBreakpoint_entry() != NULL) {
71 intptr_t index = 71 intptr_t index =
72 FindExternalLabel(&StubCode::BreakpointRuntimeLabel(), kNotPatchable); 72 FindExternalLabel(&StubCode::ICCallBreakpointLabel(),
73 ASSERT(index == kBreakpointRuntimeCPIndex); 73 kNotPatchable);
74 ASSERT(index == kICCallBreakpointCPIndex);
74 } else { 75 } else {
75 object_pool_.Add(vacant, Heap::kOld); 76 object_pool_.Add(vacant, Heap::kOld);
76 patchable_pool_entries_.Add(kNotPatchable); 77 patchable_pool_entries_.Add(kNotPatchable);
78 }
79 if (StubCode::ClosureCallBreakpoint_entry() != NULL) {
80 intptr_t index =
81 FindExternalLabel(&StubCode::ClosureCallBreakpointLabel(),
82 kNotPatchable);
83 ASSERT(index == kClosureCallBreakpointCPIndex);
84 } else {
85 object_pool_.Add(vacant, Heap::kOld);
86 patchable_pool_entries_.Add(kNotPatchable);
87 }
88 if (StubCode::RuntimeCallBreakpoint_entry() != NULL) {
89 intptr_t index =
90 FindExternalLabel(&StubCode::RuntimeCallBreakpointLabel(),
91 kNotPatchable);
92 ASSERT(index == kRuntimeCallBreakpointCPIndex);
93 } else {
94 object_pool_.Add(vacant, Heap::kOld);
95 patchable_pool_entries_.Add(kNotPatchable);
77 } 96 }
78 } 97 }
79 } 98 }
80 99
81 100
82 void Assembler::InitializeMemoryWithBreakpoints(uword data, intptr_t length) { 101 void Assembler::InitializeMemoryWithBreakpoints(uword data, intptr_t length) {
83 ASSERT(Utils::IsAligned(data, 4)); 102 ASSERT(Utils::IsAligned(data, 4));
84 ASSERT(Utils::IsAligned(length, 4)); 103 ASSERT(Utils::IsAligned(length, 4));
85 const uword end = data + length; 104 const uword end = data + length;
86 while (data < end) { 105 while (data < end) {
(...skipping 1294 matching lines...) Expand 10 before | Expand all | Expand 10 after
1381 LoadImmediate(TMP, tags, pp); 1400 LoadImmediate(TMP, tags, pp);
1382 StoreFieldToOffset(TMP, instance_reg, Object::tags_offset(), pp); 1401 StoreFieldToOffset(TMP, instance_reg, Object::tags_offset(), pp);
1383 } else { 1402 } else {
1384 b(failure); 1403 b(failure);
1385 } 1404 }
1386 } 1405 }
1387 1406
1388 } // namespace dart 1407 } // namespace dart
1389 1408
1390 #endif // defined TARGET_ARCH_ARM64 1409 #endif // defined TARGET_ARCH_ARM64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698