Specialize breakpoint stubs by set of live registers of the stubs they are intercepting.

runtime/vm/debugger_x64.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/debugger.h"
 
 #include "vm/assembler.h"
@@ skipping 37 matching lines @@
 
 
 void CodeBreakpoint::PatchCode() {
   ASSERT(!is_enabled_);
   const Code& code = Code::Handle(code_);
   const Instructions& instrs = Instructions::Handle(code.instructions());
   {
     WritableInstructionsScope writable(instrs.EntryPoint(), instrs.size());
     switch (breakpoint_kind_) {
       case RawPcDescriptors::kIcCall:
-      case RawPcDescriptors::kUnoptStaticCall:
-      case RawPcDescriptors::kRuntimeCall:
+      case RawPcDescriptors::kUnoptStaticCall: {
+        int32_t offset = CodePatcher::GetPoolOffsetAt(pc_);
+        ASSERT((offset > 0) && ((offset % 8) == 7));
+        saved_value_ = static_cast<uword>(offset);
+        const uint32_t stub_offset =
+            InstructionPattern::OffsetFromPPIndex(
+                Assembler::kICCallBreakpointCPIndex);
+        CodePatcher::SetPoolOffsetAt(pc_, stub_offset);
+        break;
+      }
       case RawPcDescriptors::kClosureCall: {
         int32_t offset = CodePatcher::GetPoolOffsetAt(pc_);
         ASSERT((offset > 0) && ((offset % 8) == 7));
         saved_value_ = static_cast<uword>(offset);
         const uint32_t stub_offset =
             InstructionPattern::OffsetFromPPIndex(
-                Assembler::kBreakpointRuntimeCPIndex);
+                Assembler::kClosureCallBreakpointCPIndex);
         CodePatcher::SetPoolOffsetAt(pc_, stub_offset);
         break;
       }
+      case RawPcDescriptors::kRuntimeCall: {
+        int32_t offset = CodePatcher::GetPoolOffsetAt(pc_);
+        ASSERT((offset > 0) && ((offset % 8) == 7));
+        saved_value_ = static_cast<uword>(offset);
+        const uint32_t stub_offset =
+            InstructionPattern::OffsetFromPPIndex(
+                Assembler::kRuntimeCallBreakpointCPIndex);
+        CodePatcher::SetPoolOffsetAt(pc_, stub_offset);
+        break;
+      }
       default:
         UNREACHABLE();
     }
   }
   is_enabled_ = true;
 }
 
 
 void CodeBreakpoint::RestoreCode() {
   ASSERT(is_enabled_);
@@ skipping 13 matching lines @@
         UNREACHABLE();
     }
   }
   is_enabled_ = false;
 }
 
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64