Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: runtime/vm/assembler_x64.cc

Issue 339183010: Specialize breakpoint stubs by set of live registers of the stubs they are intercepting. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/assembler_x64.h ('k') | runtime/vm/debugger_arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/cpu.h" 9 #include "vm/cpu.h"
10 #include "vm/heap.h" 10 #include "vm/heap.h"
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 patchable_pool_entries_.Add(kNotPatchable); 57 patchable_pool_entries_.Add(kNotPatchable);
58 } 58 }
59 59
60 if (StubCode::CallToRuntime_entry() != NULL) { 60 if (StubCode::CallToRuntime_entry() != NULL) {
61 FindExternalLabel(&StubCode::CallToRuntimeLabel(), kNotPatchable); 61 FindExternalLabel(&StubCode::CallToRuntimeLabel(), kNotPatchable);
62 } else { 62 } else {
63 object_pool_.Add(vacant, Heap::kOld); 63 object_pool_.Add(vacant, Heap::kOld);
64 patchable_pool_entries_.Add(kNotPatchable); 64 patchable_pool_entries_.Add(kNotPatchable);
65 } 65 }
66 66
67 // Create fixed object pool entry for debugger stub. 67 // Create fixed object pool entries for debugger stubs.
68 if (StubCode::BreakpointRuntime_entry() != NULL) { 68 if (StubCode::ICCallBreakpoint_entry() != NULL) {
69 intptr_t index = 69 intptr_t index =
70 FindExternalLabel(&StubCode::BreakpointRuntimeLabel(), kNotPatchable); 70 FindExternalLabel(&StubCode::ICCallBreakpointLabel(),
71 ASSERT(index == kBreakpointRuntimeCPIndex); 71 kNotPatchable);
72 ASSERT(index == kICCallBreakpointCPIndex);
72 } else { 73 } else {
73 object_pool_.Add(vacant, Heap::kOld); 74 object_pool_.Add(vacant, Heap::kOld);
74 patchable_pool_entries_.Add(kNotPatchable); 75 patchable_pool_entries_.Add(kNotPatchable);
76 }
77 if (StubCode::ClosureCallBreakpoint_entry() != NULL) {
78 intptr_t index =
79 FindExternalLabel(&StubCode::ClosureCallBreakpointLabel(),
80 kNotPatchable);
81 ASSERT(index == kClosureCallBreakpointCPIndex);
82 } else {
83 object_pool_.Add(vacant, Heap::kOld);
84 patchable_pool_entries_.Add(kNotPatchable);
85 }
86 if (StubCode::RuntimeCallBreakpoint_entry() != NULL) {
87 intptr_t index =
88 FindExternalLabel(&StubCode::RuntimeCallBreakpointLabel(),
89 kNotPatchable);
90 ASSERT(index == kRuntimeCallBreakpointCPIndex);
91 } else {
92 object_pool_.Add(vacant, Heap::kOld);
93 patchable_pool_entries_.Add(kNotPatchable);
75 } 94 }
76 } 95 }
77 } 96 }
78 97
79 98
80 void Assembler::InitializeMemoryWithBreakpoints(uword data, intptr_t length) { 99 void Assembler::InitializeMemoryWithBreakpoints(uword data, intptr_t length) {
81 memset(reinterpret_cast<void*>(data), Instr::kBreakPointInstruction, length); 100 memset(reinterpret_cast<void*>(data), Instr::kBreakPointInstruction, length);
82 } 101 }
83 102
84 103
(...skipping 3319 matching lines...) Expand 10 before | Expand all | Expand 10 after
3404 3423
3405 3424
3406 const char* Assembler::FpuRegisterName(FpuRegister reg) { 3425 const char* Assembler::FpuRegisterName(FpuRegister reg) {
3407 ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters)); 3426 ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters));
3408 return xmm_reg_names[reg]; 3427 return xmm_reg_names[reg];
3409 } 3428 }
3410 3429
3411 } // namespace dart 3430 } // namespace dart
3412 3431
3413 #endif // defined TARGET_ARCH_X64 3432 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/assembler_x64.h ('k') | runtime/vm/debugger_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698