Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Side by Side Diff: runtime/vm/assembler_arm64.cc

Issue 339183010: Specialize breakpoint stubs by set of live registers of the stubs they are intercepting. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/assembler_arm64.h ('k') | runtime/vm/assembler_x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/cpu.h" 9 #include "vm/cpu.h"
10 #include "vm/longjump.h" 10 #include "vm/longjump.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 patchable_pool_entries_.Add(kNotPatchable); 60 patchable_pool_entries_.Add(kNotPatchable);
61 } 61 }
62 62
63 if (StubCode::CallToRuntime_entry() != NULL) { 63 if (StubCode::CallToRuntime_entry() != NULL) {
64 FindExternalLabel(&StubCode::CallToRuntimeLabel(), kNotPatchable); 64 FindExternalLabel(&StubCode::CallToRuntimeLabel(), kNotPatchable);
65 } else { 65 } else {
66 object_pool_.Add(vacant, Heap::kOld); 66 object_pool_.Add(vacant, Heap::kOld);
67 patchable_pool_entries_.Add(kNotPatchable); 67 patchable_pool_entries_.Add(kNotPatchable);
68 } 68 }
69 69
70 // Create fixed object pool entry for debugger stub. 70 // Create fixed object pool entries for debugger stubs.
71 if (StubCode::BreakpointRuntime_entry() != NULL) { 71 if (StubCode::ICCallBreakpoint_entry() != NULL) {
72 intptr_t index = 72 intptr_t index =
73 FindExternalLabel(&StubCode::BreakpointRuntimeLabel(), kNotPatchable); 73 FindExternalLabel(&StubCode::ICCallBreakpointLabel(),
74 ASSERT(index == kBreakpointRuntimeCPIndex); 74 kNotPatchable);
75 ASSERT(index == kICCallBreakpointCPIndex);
75 } else { 76 } else {
76 object_pool_.Add(vacant, Heap::kOld); 77 object_pool_.Add(vacant, Heap::kOld);
77 patchable_pool_entries_.Add(kNotPatchable); 78 patchable_pool_entries_.Add(kNotPatchable);
79 }
80 if (StubCode::ClosureCallBreakpoint_entry() != NULL) {
81 intptr_t index =
82 FindExternalLabel(&StubCode::ClosureCallBreakpointLabel(),
83 kNotPatchable);
84 ASSERT(index == kClosureCallBreakpointCPIndex);
85 } else {
86 object_pool_.Add(vacant, Heap::kOld);
87 patchable_pool_entries_.Add(kNotPatchable);
88 }
89 if (StubCode::RuntimeCallBreakpoint_entry() != NULL) {
90 intptr_t index =
91 FindExternalLabel(&StubCode::RuntimeCallBreakpointLabel(),
92 kNotPatchable);
93 ASSERT(index == kRuntimeCallBreakpointCPIndex);
94 } else {
95 object_pool_.Add(vacant, Heap::kOld);
96 patchable_pool_entries_.Add(kNotPatchable);
78 } 97 }
79 } 98 }
80 } 99 }
81 100
82 101
83 void Assembler::InitializeMemoryWithBreakpoints(uword data, intptr_t length) { 102 void Assembler::InitializeMemoryWithBreakpoints(uword data, intptr_t length) {
84 ASSERT(Utils::IsAligned(data, 4)); 103 ASSERT(Utils::IsAligned(data, 4));
85 ASSERT(Utils::IsAligned(length, 4)); 104 ASSERT(Utils::IsAligned(length, 4));
86 const uword end = data + length; 105 const uword end = data + length;
87 while (data < end) { 106 while (data < end) {
(...skipping 1307 matching lines...) Expand 10 before | Expand all | Expand 10 after
1395 LoadImmediate(TMP, tags, pp); 1414 LoadImmediate(TMP, tags, pp);
1396 StoreFieldToOffset(TMP, instance_reg, Object::tags_offset(), pp); 1415 StoreFieldToOffset(TMP, instance_reg, Object::tags_offset(), pp);
1397 } else { 1416 } else {
1398 b(failure); 1417 b(failure);
1399 } 1418 }
1400 } 1419 }
1401 1420
1402 } // namespace dart 1421 } // namespace dart
1403 1422
1404 #endif // defined TARGET_ARCH_ARM64 1423 #endif // defined TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « runtime/vm/assembler_arm64.h ('k') | runtime/vm/assembler_x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698