Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Issue 339183007: Revert of Linux sandbox: add sandbox_linux_unittests.isolate (Closed)

Created:
6 years, 6 months ago by jln (very slow on Chromium)
Modified:
6 years, 6 months ago
Reviewers:
Vadim Sh., nodir, M-A Ruel
CC:
chromium-reviews, agl, jln+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Linux sandbox: add sandbox_linux_unittests.isolate (https://codereview.chromium.org/340523006/) Reason for revert: Breaking linux_chromium_clang_dbg [7609/24970 | 449.637] SOLINK lib/libmojo_launcher.so FAILED: cd ../../sandbox; python ../tools/isolate_driver.py check --isolated "../out/Debug/sandbox_linux_unittests.isolated" --isolate "linux/sandbox_linux_unittests.isolate" --path-variable DEPTH .. --path-variable PRODUCT_DIR "../out/Debug " --extra-variable "version_full=37.0.2056.0" --config-variable "OS=linux" --config-variable "chromeos=0" --config-variable "component=shared_library" --config-variable "internal_gles2_conform_tests=0" --config-variable "icu_use_data_file_flag=1" --config-variable "libpeer_target_type=static_library" --config-variable "use_openssl=0" --ignore_broken_items Traceback (most recent call last): File "../tools/isolate_driver.py", line 279, in <module> sys.exit(main()) File "../tools/isolate_driver.py", line 269, in main create_wrapper(args, isolate, isolated) File "../tools/isolate_driver.py", line 194, in create_wrapper assert os.path.basename(isolate) == isolate, isolate AssertionError: linux/sandbox_linux_unittests.isolate ninja: build stopped: subcommand failed. Original issue's description: > Linux sandbox: add sandbox_linux_unittests.isolate > > BUG=384514 > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277867 TBR=nodir@chromium.org,vadimsh@chromium.org,maruel@chromium.org NOTREECHECKS=true NOTRY=true BUG=384514 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277875

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -41 lines) Patch
M sandbox/linux/sandbox_linux.gypi View 1 chunk +0 lines, -18 lines 0 comments Download
D sandbox/linux/sandbox_linux_unittests.isolate View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jln (very slow on Chromium)
Created Revert of Linux sandbox: add sandbox_linux_unittests.isolate
6 years, 6 months ago (2014-06-17 21:46:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/339183007/1
6 years, 6 months ago (2014-06-17 21:47:15 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 21:49:24 UTC) #3
Message was sent while issue was closed.
Change committed as 277875

Powered by Google App Engine
This is Rietveld 408576698