Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 339183006: Update the background color for the Safe Browsing interstitial (Closed)

Created:
6 years, 6 months ago by felt
Modified:
6 years, 6 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Update the background color for the Safe Browsing interstitial Makes the background color meet minimum accessibility (contrast) requirements by deepening the shade of red. BUG=381260 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278026

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fixed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M chrome/browser/resources/ssl/interstitial_v2.css View 1 3 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
felt
Hi Dan, I've been asked to update the background color for better accessibility. PTAL. Thanks ...
6 years, 6 months ago (2014-06-17 21:30:43 UTC) #1
Dan Beam
lgtm https://codereview.chromium.org/339183006/diff/1/chrome/browser/resources/ssl/interstitial_v2.css File chrome/browser/resources/ssl/interstitial_v2.css (right): https://codereview.chromium.org/339183006/diff/1/chrome/browser/resources/ssl/interstitial_v2.css#newcode10 chrome/browser/resources/ssl/interstitial_v2.css:10: background-color: rgb(247, 247, 247); nit: #hex https://codereview.chromium.org/339183006/diff/1/chrome/browser/resources/ssl/interstitial_v2.css#newcode121 chrome/browser/resources/ssl/interstitial_v2.css:121: ...
6 years, 6 months ago (2014-06-17 21:38:34 UTC) #2
felt
https://codereview.chromium.org/339183006/diff/1/chrome/browser/resources/ssl/interstitial_v2.css File chrome/browser/resources/ssl/interstitial_v2.css (right): https://codereview.chromium.org/339183006/diff/1/chrome/browser/resources/ssl/interstitial_v2.css#newcode10 chrome/browser/resources/ssl/interstitial_v2.css:10: background-color: rgb(247, 247, 247); On 2014/06/17 21:38:34, Dan Beam ...
6 years, 6 months ago (2014-06-17 23:16:37 UTC) #3
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-17 23:17:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/339183006/20001
6 years, 6 months ago (2014-06-17 23:19:22 UTC) #5
felt
The CQ bit was unchecked by felt@chromium.org
6 years, 6 months ago (2014-06-18 05:09:35 UTC) #6
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-18 05:09:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/339183006/20001
6 years, 6 months ago (2014-06-18 05:10:32 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 10:55:04 UTC) #9
Message was sent while issue was closed. 
Change committed as 278026

Powered by Google App Engine
This is Rietveld 408576698