Source/web/FrameLoaderClientImpl.cpp - Issue 339133004: Removed the frame parameter from didChangeBrandColor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 339133004: Removed the frame parameter from didChangeBrandColor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: address comment Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/FrameLoaderClientImpl.cpp

diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp

index d3039f99bc06a58b3ebb82c351da83002c21677c..70a2c09720ecd978c4a60c96eb5d2ad1c6391343 100644

--- a/Source/web/FrameLoaderClientImpl.cpp

+++ b/Source/web/FrameLoaderClientImpl.cpp

@@ -452,8 +452,8 @@ void FrameLoaderClientImpl::dispatchDidFirstVisuallyNonEmptyLayout()

void FrameLoaderClientImpl::dispatchDidChangeBrandColor()

{

- if (m_webFrame->client())

- m_webFrame->client()->didChangeBrandColor(m_webFrame);

+ if (m_webFrame->client() && !m_webFrame->parent())

+ m_webFrame->client()->didChangeBrandColor();

abarth-chromium 2014/06/17 21:52:48 This change isn't correct. You're welcome to igno

}

NavigationPolicy FrameLoaderClientImpl::decidePolicyForNavigation(const ResourceRequest& request, DocumentLoader* loader, NavigationPolicy policy)

« no previous file with comments | « no previous file | Source/web/tests/WebFrameTest.cpp » ('j') | public/web/WebFrameClient.h » ('J')