Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1670)

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 339133004: Removed the frame parameter from didChangeBrandColor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/FrameLoaderClientImpl.cpp ('k') | public/web/WebFrameClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/WebFrameTest.cpp
diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp
index 7ec49c36674ca3ab4768b7464b26e7f0e0950cad..f871c90e18a5e910977ad98e099af08d4e98215e 100644
--- a/Source/web/tests/WebFrameTest.cpp
+++ b/Source/web/tests/WebFrameTest.cpp
@@ -5548,7 +5548,6 @@ class BrandColorTestWebFrameClient : public FrameTestHelpers::TestWebFrameClient
public:
BrandColorTestWebFrameClient()
: m_didNotify(false)
- , m_brandColor(0)
{
}
@@ -5557,20 +5556,13 @@ public:
return m_didNotify;
}
- WebColor brandColor() const
- {
- return m_brandColor;
- }
-
private:
- virtual void didChangeBrandColor(WebLocalFrame* webLocalFrame)
+ virtual void didChangeBrandColor()
{
m_didNotify = true;
- m_brandColor = webLocalFrame->document().brandColor();
}
bool m_didNotify;
- WebColor m_brandColor;
};
TEST_F(WebFrameTest, BrandColor)
@@ -5580,7 +5572,7 @@ TEST_F(WebFrameTest, BrandColor)
BrandColorTestWebFrameClient client;
webViewHelper.initializeAndLoad(m_baseURL + "brand_color_test.html", false, &client);
EXPECT_TRUE(client.didNotify());
- EXPECT_EQ(0xff0000ff, client.brandColor());
+ EXPECT_EQ(0xff0000ff, webViewHelper.webView()->mainFrame()->document().brandColor());
dcheng 2014/06/17 16:51:55 The site isolation team hasn't had enough cycles t
michaelbai 2014/06/17 17:06:08 Done. Is there any document about how to add web
}
} // namespace
« no previous file with comments | « Source/web/FrameLoaderClientImpl.cpp ('k') | public/web/WebFrameClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698