Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: public/web/WebFrameClient.h

Issue 339133004: Removed the frame parameter from didChangeBrandColor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address comment Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 260
261 // Called upon update to scroll position, document state, and other 261 // Called upon update to scroll position, document state, and other
262 // non-navigational events related to the data held by WebHistoryItem. 262 // non-navigational events related to the data held by WebHistoryItem.
263 // WARNING: This method may be called very frequently. 263 // WARNING: This method may be called very frequently.
264 virtual void didUpdateCurrentHistoryItem(WebLocalFrame*) { } 264 virtual void didUpdateCurrentHistoryItem(WebLocalFrame*) { }
265 265
266 // The frame's manifest has changed. 266 // The frame's manifest has changed.
267 virtual void didChangeManifest(WebLocalFrame*) { } 267 virtual void didChangeManifest(WebLocalFrame*) { }
268 268
269 // The frame's brand color has changed. 269 // The frame's brand color has changed.
270 virtual void didChangeBrandColor(WebLocalFrame*) { } 270 virtual void didChangeBrandColor() { }
abarth-chromium 2014/06/17 21:52:48 This change isn't correct. We always pass WebLoca
jam 2014/06/17 22:45:05 Adam: this was originally done since the WebFrameC
271 271
272 272
273 // Misc ---------------------------------------------------------------- 273 // Misc ----------------------------------------------------------------
274 274
275 // Called to retrieve the provider of desktop notifications. 275 // Called to retrieve the provider of desktop notifications.
276 virtual WebNotificationPresenter* notificationPresenter() { return 0; } 276 virtual WebNotificationPresenter* notificationPresenter() { return 0; }
277 277
278 278
279 // Editing ------------------------------------------------------------- 279 // Editing -------------------------------------------------------------
280 280
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
518 // Access the embedder API for (client-based) screen orientation client . 518 // Access the embedder API for (client-based) screen orientation client .
519 virtual WebScreenOrientationClient* webScreenOrientationClient() { return 0; } 519 virtual WebScreenOrientationClient* webScreenOrientationClient() { return 0; }
520 520
521 protected: 521 protected:
522 virtual ~WebFrameClient() { } 522 virtual ~WebFrameClient() { }
523 }; 523 };
524 524
525 } // namespace blink 525 } // namespace blink
526 526
527 #endif 527 #endif
OLDNEW
« Source/web/FrameLoaderClientImpl.cpp ('K') | « Source/web/tests/WebFrameTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698