Issue 339133002: DevTools: Fix test inspector-protocol/stylesheet-tracking-restart.html flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339133002: DevTools: Fix test inspector-protocol/stylesheet-tracking-restart.html flakiness (Closed)

Created:
6 years, 6 months ago by vsevik

Modified:
6 years, 6 months ago

Reviewers:
lushnikov

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Fix test inspector-protocol/stylesheet-tracking-restart.html flakiness The flakiness is caused by unpredictable order of stylesheets binding in InspectorCSSAgent. This patch replaces HashSet with Vector to make sure the order is maintained. R=lushnikov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176301

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -8 lines)			Patch
	M	LayoutTests/TestExpectations	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	Source/core/inspector/InspectorCSSAgent.cpp	View		2 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/339133002/1

6 years, 6 months ago (2014-06-17 07:58:19 UTC) #4

Message was sent while issue was closed.

Change committed as 176301

Expand Messages | Collapse Messages