chrome/test/data/extensions/platform_apps/ephemeral_launcher/app_with_permissions/main.js - Issue 339103002: Update the EphemeralAppLauncher for use by the webstorePrivate API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/platform_apps/ephemeral_launcher/app_with_permissions/main.js

Issue 339103002: Update the EphemeralAppLauncher for use by the webstorePrivate API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self nit Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/webstore_standalone_installer.cc ('K') | « chrome/test/data/extensions/platform_apps/ephemeral_launcher/app_with_permissions/index.html ('k') | chrome/test/data/extensions/platform_apps/ephemeral_launcher/app_with_permissions/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/platform_apps/ephemeral_launcher/app_with_permissions/main.js

diff --git a/chrome/test/data/extensions/platform_apps/ephemeral_apps/notification_settings/main.js b/chrome/test/data/extensions/platform_apps/ephemeral_launcher/app_with_permissions/main.js

similarity index 64%

copy from chrome/test/data/extensions/platform_apps/ephemeral_apps/notification_settings/main.js

copy to chrome/test/data/extensions/platform_apps/ephemeral_launcher/app_with_permissions/main.js

index f9e810e42ff1bd622db77616104cfe0089f1abc7..0c87128245e76f3f22225a13852958b094e5a29b 100644

--- a/chrome/test/data/extensions/platform_apps/ephemeral_apps/notification_settings/main.js

+++ b/chrome/test/data/extensions/platform_apps/ephemeral_launcher/app_with_permissions/main.js

@@ -3,5 +3,8 @@

// found in the LICENSE file.

chrome.app.runtime.onLaunched.addListener(function() {

- chrome.app.window.create('index.html', {});

+ chrome.app.window.create('index.html', {}, function(win) {

+ chrome.test.sendMessage('launched');

+ win.close();

+ });

});